Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761170AbYHHUwc (ORCPT ); Fri, 8 Aug 2008 16:52:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760703AbYHHUwN (ORCPT ); Fri, 8 Aug 2008 16:52:13 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:37477 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760356AbYHHUwL (ORCPT ); Fri, 8 Aug 2008 16:52:11 -0400 Date: Fri, 8 Aug 2008 13:46:57 -0700 From: Andrew Morton To: Peter Zijlstra Cc: paulmck@linux.vnet.ibm.com, torvalds@linux-foundation.org, mingo@elte.hu, tglx@linutronix.de, marcin.slusarz@gmail.com, linux-kernel@vger.kernel.org, davem@davemloft.net, rostedt@goodmis.org Subject: Re: [PATCH] printk: robustify printk Message-Id: <20080808134657.fe439e56.akpm@linux-foundation.org> In-Reply-To: <1218227859.29098.24.camel@lappy.programming.kicks-ass.net> References: <1218202249.8625.106.camel@twins> <1218215454.8625.133.camel@twins> <1218217257.29098.2.camel@lappy.programming.kicks-ass.net> <1218219269.29098.5.camel@lappy.programming.kicks-ass.net> <20080808121428.646a8b3c.akpm@linux-foundation.org> <1218223269.29098.12.camel@lappy.programming.kicks-ass.net> <20080808123747.0db1c5dd.akpm@linux-foundation.org> <20080808203241.GH6760@linux.vnet.ibm.com> <1218227859.29098.24.camel@lappy.programming.kicks-ass.net> X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.8.20; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1012 Lines: 26 On Fri, 08 Aug 2008 22:37:39 +0200 Peter Zijlstra wrote: > On Fri, 2008-08-08 at 13:32 -0700, Paul E. McKenney wrote: > > > How about if I instead add comments warning people not to put printk() > > in the relevant RCU-implementation code? That way I can be not only lazy, > > but cowardly as well! ;-) > > Well, it does spoil the party a little, we are now trading one deadlock > for another :-/ > Yup. We could just as easily put those comments into the scheduler wakeup code. Why are we fixing this, btw? The problem has been there forever and people who hack the wakeup code could/should know about it anyway. All they need to do is to disable klogd during development. Did the problem recently become worse for some reason? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/