Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761254AbYHHVP6 (ORCPT ); Fri, 8 Aug 2008 17:15:58 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754239AbYHHVPu (ORCPT ); Fri, 8 Aug 2008 17:15:50 -0400 Received: from sh.osrg.net ([192.16.179.4]:53538 "EHLO sh.osrg.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753245AbYHHVPu (ORCPT ); Fri, 8 Aug 2008 17:15:50 -0400 Date: Sat, 9 Aug 2008 06:13:36 +0900 To: jbarnes@virtuousgeek.org Cc: prarit@redhat.com, muli@il.ibm.com, fujita.tomonori@lab.ntt.co.jp, joro@8bytes.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, jakub@redhat.com Subject: Re: [PATCH]: PCI: GART iommu alignment fixes [v2] From: FUJITA Tomonori In-Reply-To: <200808080915.52459.jbarnes@virtuousgeek.org> References: <20080808071244.GB6931@il.ibm.com> <489C63D1.1000407@redhat.com> <200808080915.52459.jbarnes@virtuousgeek.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-Id: <20080809061348V.fujita.tomonori@lab.ntt.co.jp> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1190 Lines: 22 On Fri, 8 Aug 2008 09:15:51 -0700 Jesse Barnes wrote: > On Friday, August 8, 2008 8:18 am Prarit Bhargava wrote: > > --- a/include/linux/dma-mapping.h > > +++ b/include/linux/dma-mapping.h > > @@ -78,7 +78,7 @@ static inline unsigned int dma_set_max_seg_size(struct > > device > > static inline unsigned long dma_get_seg_boundary(struct device *dev) > > { > > return dev->dma_parms ? > > - dev->dma_parms->segment_boundary_mask : 0xffffffff; > > + dev->dma_parms->segment_boundary_mask : 0xffffffffUL; > > } > > Yeah generally you need to cast values like this when working with real > unsigned long values rather than ints, but this *should* still be safe > (barring a compiler bug). The return type is unsigned long, so even if you > just return 0xffffffff the right thing should still happen... I told Prarid that the overflow should not happen here again and again... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/