Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760023AbYHHV3E (ORCPT ); Fri, 8 Aug 2008 17:29:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756423AbYHHV2x (ORCPT ); Fri, 8 Aug 2008 17:28:53 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:45922 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755627AbYHHV2w (ORCPT ); Fri, 8 Aug 2008 17:28:52 -0400 Date: Fri, 8 Aug 2008 14:28:47 -0700 From: Andrew Morton To: "Yinghai Lu" Cc: linux-kernel@vger.kernel.org, mm-commits@vger.kernel.org, rene.herman@keyaccess.nl, rene.herman@gmail.com Subject: Re: + x86-kill-arch-x86-kernel-mpparsec-debugging-printk.patch added to -mm tree Message-Id: <20080808142847.9e4f33b2.akpm@linux-foundation.org> In-Reply-To: <86802c440808081413u2249fff1g1940ff472cdf10e7@mail.gmail.com> References: <200808082051.m78KpZGC027833@imap1.linux-foundation.org> <86802c440808081413u2249fff1g1940ff472cdf10e7@mail.gmail.com> X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.8.20; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 956 Lines: 22 On Fri, 8 Aug 2008 14:13:29 -0700 "Yinghai Lu" wrote: > > commit 11a62a056093a7f25f1595fbd8bd5f93559572b6 turns some formerly nopped > > debugging printks in arch/x86/kernel/mppparse.c into regular ones. The > > one at the top of smp_scan_config() in particular also prints on > > !CONFIG_SMP/CONFIG_X86_LOCAL_APIC kernels and UP machines without anything > > resembling MP tables which makes their lowly UP owners wonder... > > > > Given that it was up to this point also not considered valuable user-level > > information, let's just kill that one. > > > > why? that just three lines debug debug info. For the reasons described in the changelog text. They look quite valid to me. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/