Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757277AbYHHWbl (ORCPT ); Fri, 8 Aug 2008 18:31:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758390AbYHHWba (ORCPT ); Fri, 8 Aug 2008 18:31:30 -0400 Received: from tundra.namei.org ([65.99.196.166]:47520 "EHLO tundra.namei.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755401AbYHHWb3 (ORCPT ); Fri, 8 Aug 2008 18:31:29 -0400 Date: Sat, 9 Aug 2008 08:31:06 +1000 (EST) From: James Morris To: Eduardo Habkost cc: Stephen Rothwell , David Howells , linux-next@vger.kernel.org, LKML Subject: Re: next-20080808 fs/nfsctl.c build error In-Reply-To: <20080808172527.GB4742@blackpad> Message-ID: References: <20080808171624.24ae1e10.sfr@canb.auug.org.au> <20080808172527.GB4742@blackpad> User-Agent: Alpine 1.10 (LRH 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1684 Lines: 64 On Fri, 8 Aug 2008, Eduardo Habkost wrote: > > I got the following build error on next-20080808: > > fs/nfsctl.c: In function ?do_open?: > fs/nfsctl.c:45: error: implicit declaration of function ?current_cred? > fs/nfsctl.c:45: warning: passing argument 4 of ?dentry_open? makes pointer from integer without a cast > make[1]: *** [fs/nfsctl.o] Error 1 > make: *** [fs/nfsctl.o] Error 2 Something I noticed in the configs posted with build breakages is CONFIG_SMP=n, although I'm not sure how/if that's related. In any case, it seems that linux/cred.h should include linux/sched.h to provide a full definition of 'struct task_struct', so that 'current' can be dereferenced (e.g. in current_cred()). Does this patch work for you and look correct ? ---- diff --git a/fs/nfsctl.c b/fs/nfsctl.c index cc4ef26..f6967b6 100644 --- a/fs/nfsctl.c +++ b/fs/nfsctl.c @@ -14,6 +14,7 @@ #include #include #include +#include #include /* diff --git a/include/linux/cred.h b/include/linux/cred.h index b156ed4..431f1ab 100644 --- a/include/linux/cred.h +++ b/include/linux/cred.h @@ -14,9 +14,9 @@ #include #include +#include #include -struct user_struct; struct cred; struct inode; --- Signed-off-by: James Morris -- James Morris -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/