Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762213AbYHHW6d (ORCPT ); Fri, 8 Aug 2008 18:58:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754954AbYHHW60 (ORCPT ); Fri, 8 Aug 2008 18:58:26 -0400 Received: from khc.piap.pl ([195.187.100.11]:45579 "EHLO khc.piap.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753533AbYHHW6Z convert rfc822-to-8bit (ORCPT ); Fri, 8 Aug 2008 18:58:25 -0400 To: Grant Coady Cc: Alan Cox , "Robert P. J. Day" , Linux Kernel Mailing List Subject: Re: [RFC PATCH] cleanup Serial ATA and Parallel ATA Kconfig References: <20080808172629.232bed01@lxorguk.ukuu.org.uk> From: Krzysztof Halasa Date: Sat, 09 Aug 2008 00:58:22 +0200 In-Reply-To: (Grant Coady's message of "Sat\, 09 Aug 2008 08\:34\:40 +1000") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1744 Lines: 37 Grant Coady writes: > ¦ ¦ --- Serial ATA (SATA) and Parallel ATA (PATA) drivers ¦ ¦ > ¦ ¦ <*> AHCI SATA support ¦ ¦ > ¦ ¦ [*] ATA ACPI Support ¦ ¦ > ¦ ¦ [ ] SATA Port Multiplier support ¦ ¦ > ¦ ¦ < > Silicon Image 3124/3132 SATA support ¦ ¦ > ¦ ¦ [*] ATA SFF support ¦ ¦ > ¦ ¦ *** Serial ATA drivers *** ¦ ¦ > ¦ ¦ < > Initio 162x SATA support ¦ ¦ > ¦ ¦ < > Intel ESB, ICH, PIIX3, PIIX4 PATA/SATA support ¦ ¦ As noted, it's both PATA and SATA. People searching for PATA-only PIIX support may have trouble locating it under SATA. Why not remove ATA SFF support visual option (or leave it for optional off-tree drivers only, if it makes sense) and SELECT it when any driver using it is selected? I'm not sure that users know they need SFF, or what's that. I think I would also ask for PATA and for SATA first: [*] PATA support [*] SATA support ... PATA drivers if "PATA support" is selected ... SATA drivers if "SATA support" is selected ... PIIX is PATA and/or SATA support is selected I guess all PATA and/or SATA drivers in a single sorted list (so PIIX doesn't break ordering). -- Krzysztof Halasa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/