Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762053AbYHIBY2 (ORCPT ); Fri, 8 Aug 2008 21:24:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761804AbYHIBYJ (ORCPT ); Fri, 8 Aug 2008 21:24:09 -0400 Received: from rhun.apana.org.au ([64.62.148.172]:37783 "EHLO arnor.apana.org.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1761673AbYHIBYI (ORCPT ); Fri, 8 Aug 2008 21:24:08 -0400 Date: Sat, 9 Aug 2008 09:23:56 +0800 From: Herbert Xu To: Suresh Siddha Cc: "H. Peter Anvin" , Wolfgang Walter , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Ingo Molnar , "viro@ZenIV.linux.org.uk" , "vegard.nossum@gmail.com" Subject: Re: Kernel oops with 2.6.26, padlock and ipsec: probably problem with fpu state changes Message-ID: <20080809012356.GA26340@gondor.apana.org.au> References: <200807171653.59177.wolfgang.walter@stwm.de> <20080806201401.GA607@linux-os.sc.intel.com> <200808071823.02364.wolfgang.walter@stwm.de> <200808081236.55172.wolfgang.walter@stwm.de> <20080808185356.GC607@linux-os.sc.intel.com> <489C97FB.2030408@zytor.com> <20080808231121.GA13158@linux-os.sc.intel.com> <20080809003829.GA25926@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080809003829.GA25926@gondor.apana.org.au> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1067 Lines: 25 On Sat, Aug 09, 2008 at 08:38:30AM +0800, Herbert Xu wrote: > > If there is a significant degradation I suggest that we back out > the FPU changes. Making your competitor's processor go slow is > not a nice thing to do, especially when you've just released a > processor in the same space. > > If the degradation is small then I'll push it to Linus. Actually the patch is totally unacceptable as it is. Disabling preemption around padlock crypto operations is going to make the latency for RT go through the roof. Please find a solution that doesn't involve that or just back out the FPU changes. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/