Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761395AbYHIBtt (ORCPT ); Fri, 8 Aug 2008 21:49:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752036AbYHIBti (ORCPT ); Fri, 8 Aug 2008 21:49:38 -0400 Received: from rhun.apana.org.au ([64.62.148.172]:45262 "EHLO arnor.apana.org.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751852AbYHIBth (ORCPT ); Fri, 8 Aug 2008 21:49:37 -0400 Date: Sat, 9 Aug 2008 09:49:25 +0800 From: Herbert Xu To: "H. Peter Anvin" Cc: Suresh Siddha , Wolfgang Walter , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Ingo Molnar , viro@ZenIV.linux.org.uk, vegard.nossum@gmail.com Subject: Re: Kernel oops with 2.6.26, padlock and ipsec: probably problem with fpu state changes Message-ID: <20080809014925.GA26529@gondor.apana.org.au> References: <200807171653.59177.wolfgang.walter@stwm.de> <20080806201401.GA607@linux-os.sc.intel.com> <200808071823.02364.wolfgang.walter@stwm.de> <200808081236.55172.wolfgang.walter@stwm.de> <20080808185356.GC607@linux-os.sc.intel.com> <489C97FB.2030408@zytor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <489C97FB.2030408@zytor.com> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1198 Lines: 28 On Fri, Aug 08, 2008 at 12:01:15PM -0700, H. Peter Anvin wrote: > > It's technically overkill, if (and only if!) these instructions don't > actually touch the SSE state (most likely they're using the SSE > pipeline, and need this stuff to deal with power management issues.) Yes the PadLock uses the SSE pipeline, but doesn't touch any of the state. > However, overkill is a good way to make sure something is dead. > Applying the patch will make sure we fix the regression, and we can > worry about optimizing this further post-2.6.27. Do we really need the FPU changes right now? I'd prefer for that to be backed out until a proper solution is found. Disabling preemption around crypto is really bad for scheduling latency. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/