Message-ID: <489D0F69.9050307@zytor.com>
Date: Fri, 08 Aug 2008 20:30:49 -0700
From: "H. Peter Anvin" <hpa@zytor.com>
User-Agent: Thunderbird 2.0.0.14 (X11/20080501)
MIME-Version: 1.0
To: Wolfgang Walter <wolfgang.walter@stwm.de>
CC: Herbert Xu <herbert@gondor.apana.org.au>,
       Suresh Siddha <suresh.b.siddha@intel.com>,
       "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
       "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
       Ingo Molnar <mingo@elte.hu>, viro@zeniv.linux.org.uk,
       vegard.nossum@gmail.com
Subject: Re: Kernel oops with 2.6.26, padlock and ipsec: probably problem
 with fpu state changes
References: <200807171653.59177.wolfgang.walter@stwm.de> <489C97FB.2030408@zytor.com> <20080809014925.GA26529@gondor.apana.org.au> <200808090443.00597.wolfgang.walter@stwm.de>
In-Reply-To: <200808090443.00597.wolfgang.walter@stwm.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 831
Lines: 23

Wolfgang Walter wrote:
> 
> These FPU changes are already in 2.6.26. Undoing them, would that be accepted 
> for 2.6.26 stable?
> 
> Maybe the following solution would be possible: if a processor with padlock is 
> detected the memory for xstate is always allocated when the thread is created 
> instead "lazy"?
> 

That will effectively happen, so it doesn't really matter.

The true optimization would be to recognize that the state doesn't have 
to be saved, and track when we did so, and so on and so forth.

VIA really did their customers a disservice tying this to CR0.TS.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/