Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759628AbYHIDun (ORCPT ); Fri, 8 Aug 2008 23:50:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753917AbYHIDuc (ORCPT ); Fri, 8 Aug 2008 23:50:32 -0400 Received: from mx1.redhat.com ([66.187.233.31]:55790 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753037AbYHIDuc (ORCPT ); Fri, 8 Aug 2008 23:50:32 -0400 Message-ID: <489D13F9.4000805@redhat.com> Date: Fri, 08 Aug 2008 23:50:17 -0400 From: Hideo AOKI User-Agent: Thunderbird 2.0.0.16 (X11/20080723) MIME-Version: 1.0 To: Herbert Xu CC: "Michael S. Tsirkin" , linux-kernel@vger.kernel.org, davem@davemloft.net, yoshfuji@linux-ipv6.org, netdev@vger.kernel.org Subject: Re: possible recursive locking in udp4_lib_rcv References: <20080807234613.GA9598@google.com> <20080808143741.GA20777@gondor.apana.org.au> <20080808150108.GA21048@gondor.apana.org.au> In-Reply-To: <20080808150108.GA21048@gondor.apana.org.au> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 679 Lines: 24 Hello Herbert, Herbert Xu wrote: > On Fri, Aug 08, 2008 at 10:37:41PM +0800, Herbert Xu wrote: >> Never mind, I see the reason why it's there. What we should do >> is drop the lock when we hit an encapsulated socket since they >> don't need it at all. > > Here is the patch: > > udp: Drop socket lock for encapsulated packets Thank very much for fixing the bug. Best regards, Hideo -- Hitachi Computer Products (America) Inc. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/