Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752876AbYHIMsX (ORCPT ); Sat, 9 Aug 2008 08:48:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751538AbYHIMsN (ORCPT ); Sat, 9 Aug 2008 08:48:13 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:50296 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750919AbYHIMsM (ORCPT ); Sat, 9 Aug 2008 08:48:12 -0400 Date: Sat, 9 Aug 2008 08:47:39 -0400 From: Christoph Hellwig To: Ian Kent Cc: Andrew Morton , autofs mailing list , Kernel Mailing List , linux-fsdevel Subject: Re: [PATCH 1/4] autofs4 - cleanup autofs mount type usage Message-ID: <20080809124739.GA16308@infradead.org> References: <20080807114002.4142.30417.stgit@web.messagingengine.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080807114002.4142.30417.stgit@web.messagingengine.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 923 Lines: 23 On Thu, Aug 07, 2008 at 07:40:06PM +0800, Ian Kent wrote: > Usage of the AUTOFS_TYPE_* defines is a little confusing and > appears inconsistent. Not enough of an explanation for this patch. It does: - move AUTOFS_TYPE_INDIRECT/AUTOFS_TYPE_DIRECT/AUTOFS_TYPE_OFFSET to include/linux/auto_fs4.h. Obviously okay but should mentioned in the changelog. - add a new, unused AUTOFS_TYPE_ANY constant. Why? - add a new AUTOFS_TYPE_TRIGGER and use it instead of AUTOFS_TYPE_DIRECT or in one single case (AUTOFS_TYPE_DIRECT|AUTOFS_TYPE_OFFSET). Definitively needs a good explanation. - replaces one use of sbi->type = 0 with AUTOFS_TYPE_INDIRECT (0x0001). Why? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/