Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753215AbYHISsQ (ORCPT ); Sat, 9 Aug 2008 14:48:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751695AbYHISsE (ORCPT ); Sat, 9 Aug 2008 14:48:04 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:56608 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751516AbYHISsC (ORCPT ); Sat, 9 Aug 2008 14:48:02 -0400 Date: Sat, 9 Aug 2008 14:47:59 -0400 From: Christoph Hellwig To: Greg KH Cc: Mimi Zohar , linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, Al Viro , Stephen Smalley , James Morris , Randy Dunlap , safford@watson.ibm.com, serue@linux.vnet.ibm.com, sailer@watson.ibm.com, zohar@us.ibm.com Subject: Re: [PATCH 2/4] integrity: special fs magic Message-ID: <20080809184759.GB22905@infradead.org> References: <20080808184349.999902616@linux.vnet.ibm.com> <1218221742.4444.12.camel@localhost.localdomain> <20080808190448.GA3356@kroah.com> <20080808191519.GA3704@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080808191519.GA3704@kroah.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1293 Lines: 29 On Fri, Aug 08, 2008 at 12:15:19PM -0700, Greg KH wrote: > On Fri, Aug 08, 2008 at 12:04:48PM -0700, Greg KH wrote: > > On Fri, Aug 08, 2008 at 02:55:42PM -0400, Mimi Zohar wrote: > > > - Move special fs magic number definitions to magic.h > > > - Add magic.h include > > > > > > Signed-off-by: Mimi Zohar > > > > Why? What is this patch for? Are you going to do something with these > > magic values later? > > Ok, I now see the follow-up patch that does something with them. > > You should say so in this patch. > > And is it really ok to be doing things from userspace based on a > filesystem "magic" key? Those are numbers we have never exported to > userspace before, what happens if they are changed? These constants re exported to userspace in struct statfs .type and better don't change. Providing the symbolic names for them sounds like a good idea to me. What userspace does with that or not is their business, and if it's utterly stupid it'll be their fault if it doesn't work as expected.. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/