Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752389AbYHISy0 (ORCPT ); Sat, 9 Aug 2008 14:54:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751948AbYHISyP (ORCPT ); Sat, 9 Aug 2008 14:54:15 -0400 Received: from mga01.intel.com ([192.55.52.88]:45420 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751695AbYHISyO (ORCPT ); Sat, 9 Aug 2008 14:54:14 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.31,334,1215414000"; d="scan'208";a="369201686" Date: Sat, 9 Aug 2008 11:54:13 -0700 From: Suresh Siddha To: Suresh Siddha Cc: Wolfgang Walter , Herbert Xu , "H. Peter Anvin" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Ingo Molnar , "viro@ZenIV.linux.org.uk" , "vegard.nossum@gmail.com" Subject: Re: Kernel oops with 2.6.26, padlock and ipsec: probably problem with fpu state changes Message-ID: <20080809185412.GI13158@linux-os.sc.intel.com> References: <200807171653.59177.wolfgang.walter@stwm.de> <20080808231121.GA13158@linux-os.sc.intel.com> <20080809143727.GA30499@gondor.apana.org.au> <200808091757.32999.wolfgang.walter@stwm.de> <20080809181219.GF13158@linux-os.sc.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080809181219.GF13158@linux-os.sc.intel.com> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 599 Lines: 12 On Sat, Aug 09, 2008 at 11:12:19AM -0700, Suresh Siddha wrote: > In this padlock case with the patch, we may encounter a nested > kernel_fpu_begin() and end() > but this is ok, as the padlock is not actually touching fpu/sse registers. I take this back. kernel_fpu_end() is unconditionally doing stts(). So, nesting of kernel_fpu_begin/end() is not ok. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/