Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753835AbYHIVHf (ORCPT ); Sat, 9 Aug 2008 17:07:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751510AbYHIVH1 (ORCPT ); Sat, 9 Aug 2008 17:07:27 -0400 Received: from relay1.sgi.com ([192.48.171.29]:42704 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751330AbYHIVH0 (ORCPT ); Sat, 9 Aug 2008 17:07:26 -0400 Date: Sat, 9 Aug 2008 16:07:21 -0500 From: Paul Jackson To: "Rakib Mullick" Cc: menage@google.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] cgroup.c: Some 'hlist_head' function fixes. Message-Id: <20080809160721.320b114d.pj@sgi.com> In-Reply-To: References: Organization: SGI X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.12.0; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 584 Lines: 17 Rabik wrote: > + i = 0; > + i = hash_long(tmp, CSS_SET_HASH_BITS); That "i = 0;" looks unnecessary to me, given that i is unconditionally set again, on the very next line. -- I won't rest till it's the best ... Programmer, Linux Scalability Paul Jackson 1.940.382.4214 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/