Date: Sat, 9 Aug 2008 16:04:22 -0600
From: Pete Zaitcev <zaitcev@redhat.com>
To: Greg KH <greg@kroah.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [00/03] [RFC] USB debugging rework
Message-Id: <20080809160422.48eae96b.zaitcev@redhat.com>
In-Reply-To: <20080809013820.GA10910@kroah.com>
References: <20080809013820.GA10910@kroah.com>
Organization: Red Hat, Inc.
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 911
Lines: 20

On Fri, 8 Aug 2008 18:38:21 -0700, Greg KH <greg@kroah.com> wrote:

> I've been annoyed for a long time that we make users go off and rebuild
> their kernels just to enable usb debug messages.  So finally, here's the
> start of fixing that issue.

In many cases usbmon does the job, and it's intended to be "always-on",
as to allow building it even on embedded kernels. Sure, it will not print
nice values of quirks and such, but that's a trade-off. I sort of hoped
that the switcheable explicit messages would generally die off. Look
at ub, it only has messages which indicate error conditions.

I'm not against your patch as such, it's a net improvement.

-- Pete
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/