Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754486AbYHJBlI (ORCPT ); Sat, 9 Aug 2008 21:41:08 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752634AbYHJBkx (ORCPT ); Sat, 9 Aug 2008 21:40:53 -0400 Received: from rhun.apana.org.au ([64.62.148.172]:60828 "EHLO arnor.apana.org.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752380AbYHJBkw (ORCPT ); Sat, 9 Aug 2008 21:40:52 -0400 Date: Sun, 10 Aug 2008 09:40:37 +0800 From: Herbert Xu To: Suresh Siddha Cc: "H. Peter Anvin" , Wolfgang Walter , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Ingo Molnar , "viro@ZenIV.linux.org.uk" , "vegard.nossum@gmail.com" Subject: Re: Kernel oops with 2.6.26, padlock and ipsec: probably problem with fpu state changes Message-ID: <20080810014037.GA1859@gondor.apana.org.au> References: <200807171653.59177.wolfgang.walter@stwm.de> <20080806201401.GA607@linux-os.sc.intel.com> <200808071823.02364.wolfgang.walter@stwm.de> <200808081236.55172.wolfgang.walter@stwm.de> <20080808185356.GC607@linux-os.sc.intel.com> <489C97FB.2030408@zytor.com> <20080808231121.GA13158@linux-os.sc.intel.com> <20080809143727.GA30499@gondor.apana.org.au> <20080809175940.GE13158@linux-os.sc.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080809175940.GE13158@linux-os.sc.intel.com> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1060 Lines: 26 On Sat, Aug 09, 2008 at 10:59:40AM -0700, Suresh Siddha wrote: > > 0. CPU's TS flag is set > > 1. kernel using FPU in some optimized copy routine and while doing > kernel_fpu_begin() takes an interrupt just before doing clts() > > 2. Takes an interrupt and ipsec uses padlock instruction. And we > take a DNA fault as TS flag is still set. Right, we could've fixed this by doing the clts before checking TS_USEDFPU in kernel_fpu_begin. However, I admit that taking a fault in the general case for the PadLock is stupid anyway so we should definitely fix this in the ways that you suggested. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/