Date: Sat, 9 Aug 2008 20:36:32 -0700
From: Greg KH <greg@kroah.com>
To: Marcin Slusarz <marcin.slusarz@gmail.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [01/03] USB: add CONFIG_USB_DEBUG_MESSAGES and usb_dbg()
Message-ID: <20080810033631.GB30733@kroah.com>
References: <20080809013820.GA10910@kroah.com> <20080809013917.GB10910@kroah.com> <20080809150439.GA5408@joi>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20080809150439.GA5408@joi>
User-Agent: Mutt/1.5.16 (2007-06-09)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 997
Lines: 32

On Sat, Aug 09, 2008 at 05:04:43PM +0200, Marcin Slusarz wrote:
> On Fri, Aug 08, 2008 at 06:39:17PM -0700, Greg KH wrote:
> > --- a/drivers/usb/core/usb.h
> > +++ b/drivers/usb/core/usb.h
> > @@ -132,6 +132,28 @@ static inline int is_active(const struct
> >  /* for labeling diagnostics */
> >  extern const char *usbcore_name;
> >  
> > +/* USB debugging */
> > +/* if debug is on or not for the USB core */
> > +extern int usb_debug;
> > +
> > +#if defined(CONFIG_USB_DEBUG_MESSAGES)
> > +/* macro for debugging */
> > +#define usb_dbg(dev, format, arg...)					\
> > +	({								\
> > +		if (usb_debug)						\
> 
> maybe unlikely here?

Does it really generate better code?

I really dislike using unlikely except for fast paths.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/