Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754229AbYHJG5Z (ORCPT ); Sun, 10 Aug 2008 02:57:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751495AbYHJG5O (ORCPT ); Sun, 10 Aug 2008 02:57:14 -0400 Received: from mail.vyatta.com ([216.93.170.194]:35540 "EHLO mail.vyatta.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751154AbYHJG5N (ORCPT ); Sun, 10 Aug 2008 02:57:13 -0400 X-Spam-Flag: NO X-Spam-Score: -1.409 Date: Sat, 9 Aug 2008 23:57:11 -0700 From: Stephen Hemminger To: "Rafael J. Wysocki" Cc: netdev@vger.kernel.org, Jeff Garzik , Stephen Hemminger , Andrew Morton , LKML Subject: Re: [PATCH] sky2: Fix suspend/hibernation/shutdown regression with WOL enabled Message-ID: <20080809235711.12c2f331@extreme> In-Reply-To: <200808092332.29596.rjw@sisk.pl> References: <200808092332.29596.rjw@sisk.pl> Organization: Vyatta X-Mailer: Claws Mail 3.3.1 (GTK+ 2.12.9; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1583 Lines: 39 On Sat, 9 Aug 2008 23:32:28 +0200 "Rafael J. Wysocki" wrote: > sky2: Fix suspend/hibernation/shutdown regression with WOL enabled > > On my test box with the Asus M3A32-MVP main board there is a > regression from 2.6.26 related to suspend, hibernation and > shutdown. Namely, if Wake-on-LAN is enabled with > 'ethtool -s eth0 wol g', the box hangs solid during all of these > operations, while executing either sky2_suspend(), or > sky2_shutdown(). This patch fixes it for me. > > Signed-off-by: Rafael J. Wysocki > --- > drivers/net/sky2.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > Index: linux-2.6/drivers/net/sky2.c > =================================================================== > --- linux-2.6.orig/drivers/net/sky2.c > +++ linux-2.6/drivers/net/sky2.c > @@ -665,7 +665,8 @@ static void sky2_phy_power_down(struct s > GM_GPCR_FL_PASS | GM_GPCR_SPEED_100 | GM_GPCR_AU_ALL_DIS); > > if (hw->chip_id != CHIP_ID_YUKON_EC) { > - if (hw->chip_id == CHIP_ID_YUKON_EC_U) { > + if (hw->chip_id == CHIP_ID_YUKON_EC_U > + && hw->chip_rev != CHIP_REV_YU_EC_U_B0) { > ctrl = gm_phy_read(hw, port, PHY_MARV_PHY_CTRL); > > /* enable Power Down */ The problem is not unique to your chip version, so patching out the power down is not the correct solution. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/