Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
	Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
	Kingdom.
	Registered in England and Wales under Company Registration No. 3798903
From: David Howells <dhowells@redhat.com>
In-Reply-To: <1218322941.24441.11.camel@brick>
References: <1218322941.24441.11.camel@brick>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: dhowells@redhat.com, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cred: remove const qualifiers
MIME-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8BIT
Date: Sun, 10 Aug 2008 11:58:36 +0100
Message-ID: <12514.1218365916@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1206
Lines: 29

Harvey Harrison <harvey.harrison@gmail.com> wrote:

> get_new_cred clearly writes through the pointer, so const isn't
> appropriate.  Sparse warns thusly:
> 
> include/linux/cred.h: In function ?get_cred?:
> include/linux/cred.h:181: warning: passing argument 1 of ?get_new_cred? discards qualifiers from pointer target type

Sparse is wrong in this instance, it failed to note the cast.  I know what I'm
doing.

> -static inline const struct cred *get_cred(const struct cred *cred)
> +static inline struct cred *get_cred(struct cred *cred)

That will break the compilation.  Please don't do that.

The point of my use of const in this instance is to stop people from trying to
modify committed credentials directly, especially current->cred.  But we still
have to be able to take a reference to it.  Unfortunately, C does not provide
the necessary tools to do what I want.

Eventually, we can probably ditch the const marks on the pointers but not yet.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/