Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755228AbYHJMNg (ORCPT ); Sun, 10 Aug 2008 08:13:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753291AbYHJMN2 (ORCPT ); Sun, 10 Aug 2008 08:13:28 -0400 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:41071 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753285AbYHJMN2 (ORCPT ); Sun, 10 Aug 2008 08:13:28 -0400 Date: Sun, 10 Aug 2008 12:54:32 +0100 From: Alan Cox To: "Rafael J. Wysocki" Cc: Grant Coady , linux-kernel@vger.kernel.org Subject: Re: Query: should 'Marvell SATA support' depend on PCI? Message-ID: <20080810125432.3504a7fa@lxorguk.ukuu.org.uk> In-Reply-To: <200808101408.11393.rjw@sisk.pl> References: <200808101408.11393.rjw@sisk.pl> X-Mailer: Claws Mail 3.5.0 (GTK+ 2.12.11; x86_64-redhat-linux-gnu) Organization: Red Hat UK Cyf., Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, Y Deyrnas Gyfunol. Cofrestrwyd yng Nghymru a Lloegr o'r rhif cofrestru 3798903 Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 713 Lines: 24 > > doesn't have 'depends on PCI && EXPERIMENTAL' like other drivers around > > it, this is okay or should it also depend on PCI? > > Well, I think so. It obviously depends on PCI. Obviously ? Try looking a bit harder /** * mv_platform_probe - handle a positive probe of an soc Marvell * host * @pdev: platform device found * * LOCKING: * Inherited from caller. */ static int mv_platform_probe(struct platform_device *pdev) Alan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/