Return-Path: <linux-kernel-owner+w=401wt.eu-S1751738AbYHKHlm@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751738AbYHKHlm (ORCPT <rfc822;w@1wt.eu>);
	Mon, 11 Aug 2008 03:41:42 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750958AbYHKHld
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Mon, 11 Aug 2008 03:41:33 -0400
Received: from oslproxyp1.tandberg.com ([194.0.215.2]:59776 "EHLO
	oslproxyp1.tandberg.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750868AbYHKHld (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 11 Aug 2008 03:41:33 -0400
Subject: Re: OOPS, ip -f inet6 route get fec0::1,
	linux-2.6.26,	ip6_route_output, rt6_fill_node+0x175
From: John Gumb <john.gumb@tandberg.com>
Reply-To: john.gumb@tandberg.com
To: Brian Haley <brian.haley@hp.com>
Cc: Alexey Dobriyan <adobriyan@gmail.com>, linux-kernel@vger.kernel.org,
       netdev@vger.kernel.org
In-Reply-To: <489BD227.6000209@hp.com>
References: <9F6ACAE02B6DD040A1E259977622CFDB033590C3@oslexcp1.eu.tandberg.int>
	 <20080807203748.GA5196@martell.zuzino.mipt.ru>  <489BD227.6000209@hp.com>
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Organization: TANDBERG Telecom UK Ltd.
Date: Mon, 11 Aug 2008 08:41:27 +0100
Message-Id: <1218440487.32543.7.camel@ukdev-lin-jag>
Mime-Version: 1.0
X-Mailer: Evolution 2.12.3 (2.12.3-5.fc8) 
X-OriginalArrivalTime: 11 Aug 2008 07:41:27.0471 (UTC) FILETIME=[A999CBF0:01C8FB85]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1558
Lines: 44

looks good to me.

thanks people.

John
On Fri, 2008-08-08 at 00:57 -0400, Brian Haley wrote:
> Alexey Dobriyan wrote:
> > On Thu, Aug 07, 2008 at 07:00:56PM +0200, John Gumb wrote:
> >> Scenario: no ipv6 default route set.
> > 
> >> # ip -f inet6 route get fec0::1
> >>
> >> BUG: unable to handle kernel NULL pointer dereference at 00000000
> >> IP: [<c0369b85>] rt6_fill_node+0x175/0x3b0
> >> EIP is at rt6_fill_node+0x175/0x3b0
> > 
> > 0xffffffff80424dd3 is in rt6_fill_node (net/ipv6/route.c:2191).
> > 2186                    } else
> > 2187    #endif
> > 2188                            NLA_PUT_U32(skb, RTA_IIF, iif);
> > 2189            } else if (dst) {
> > 2190                    struct in6_addr saddr_buf;
> > 2191      ====>         if (ipv6_dev_get_saddr(ip6_dst_idev(&rt->u.dst)->dev,
> > 					       ^^^^^^^^^^^^^^^^^^^^^^^^
> > 					       		NULL
> > 
> > 2192                                           dst, 0, &saddr_buf) == 0)
> > 2193                            NLA_PUT(skb, RTA_PREFSRC, 16, &saddr_buf);
> > 2194            }
> 
> The commit that changed this can't be reverted easily, but the patch 
> below works for me.
> 
> Fix NULL de-reference in rt6_fill_node() when there's no IPv6 input 
> device present in the dst entry.
> 
> Signed-off-by: Brian Haley <brian.haley@hp.com>
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/