Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752392AbYHKIZF (ORCPT ); Mon, 11 Aug 2008 04:25:05 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751193AbYHKIYz (ORCPT ); Mon, 11 Aug 2008 04:24:55 -0400 Received: from ns2.suse.de ([195.135.220.15]:56410 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750989AbYHKIYy (ORCPT ); Mon, 11 Aug 2008 04:24:54 -0400 Date: Mon, 11 Aug 2008 10:24:51 +0200 Message-ID: From: Takashi Iwai To: Alexander Beregalov Cc: perex@perex.cz, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [alsa-devel] [PATCH] ice1724/revo: simple clean up In-Reply-To: <20080810220904.GD5093@orion> References: <20080810220904.GD5093@orion> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.2 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1983 Lines: 57 At Mon, 11 Aug 2008 02:09:04 +0400, Alexander Beregalov wrote: > > From: Alexander Beregalov > > ice1724/revo: simple clean up > > > Signed-off-by: Alexander Beregalov Applied. Thanks. > --- > > sound/pci/ice1712/revo.c | 12 ++++++++---- > 1 files changed, 8 insertions(+), 4 deletions(-) > > diff --git a/sound/pci/ice1712/revo.c b/sound/pci/ice1712/revo.c > index 4d26314..5e1b156 100644 > --- a/sound/pci/ice1712/revo.c > +++ b/sound/pci/ice1712/revo.c > @@ -524,16 +524,20 @@ static int __devinit revo_init(struct snd_ice1712 *ice) > ak = ice->akm = kcalloc(2, sizeof(struct snd_akm4xxx), GFP_KERNEL); > if (! ak) > return -ENOMEM; > - ice->akm_codecs = 2; > switch (ice->eeprom.subvendor) { > case VT1724_SUBDEVICE_REVOLUTION71: > ice->akm_codecs = 2; > - if ((err = snd_ice1712_akm4xxx_init(ak, &akm_revo_front, &akm_revo_front_priv, ice)) < 0) > + err = snd_ice1712_akm4xxx_init(ak, &akm_revo_front, > + &akm_revo_front_priv, ice); > + if (err < 0) > return err; > - if ((err = snd_ice1712_akm4xxx_init(ak + 1, &akm_revo_surround, &akm_revo_surround_priv, ice)) < 0) > + err = snd_ice1712_akm4xxx_init(ak+1, &akm_revo_surround, > + &akm_revo_surround_priv, ice); > + if (err < 0) > return err; > /* unmute all codecs */ > - snd_ice1712_gpio_write_bits(ice, VT1724_REVO_MUTE, VT1724_REVO_MUTE); > + snd_ice1712_gpio_write_bits(ice, VT1724_REVO_MUTE, > + VT1724_REVO_MUTE); > break; > case VT1724_SUBDEVICE_REVOLUTION51: > ice->akm_codecs = 2; > _______________________________________________ > Alsa-devel mailing list > Alsa-devel@alsa-project.org > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/