Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752114AbYHKJ0B (ORCPT ); Mon, 11 Aug 2008 05:26:01 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751181AbYHKJZx (ORCPT ); Mon, 11 Aug 2008 05:25:53 -0400 Received: from qb-out-0506.google.com ([72.14.204.232]:65062 "EHLO qb-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751078AbYHKJZw (ORCPT ); Mon, 11 Aug 2008 05:25:52 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:mime-version:content-type :content-transfer-encoding:content-disposition; b=OLV6+1Q0vABTQK5GtrX6di4YYIw3CcCc0maSBRDP7eTwmeI1FGs3teEHI/twobKlrg WTT3aeMByHsac8TxYLTRnmuiI2wj5EA01Qcnjv3BhGNscfo73VeBqkLBCAJ4x9VU6RV3 gjj0A+FpfrQMMD6pGvp+2sVlOIlEbgku6Vuds= Message-ID: Date: Mon, 11 Aug 2008 15:25:51 +0600 From: "Rakib Mullick" To: "Paul Menage" , "Paul Jackson" Subject: [PATCH] cgroup.c: remove goto statement from cgroup_init. Cc: linux-kernel@vger.kernel.org MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 932 Lines: 26 Hello everyone, following patch removes the use of goto statement. Actually, we don't need it. Beacuse, if "err < 0", then it will never be TRUE. So, we can skip the goto statement and can just return. Thanks. Signed-off-by: Rakib Mullick (rakib.mullick@gmail.com) --- linux-2.6.27-rc2.orig/kernel/cgroup.c 2008-08-11 15:16:49.000000000 +0600 +++ linux-2.6.27-rc2/kernel/cgroup.c 2008-08-11 15:16:26.000000000 +0600 @@ -2562,11 +2562,10 @@ int __init cgroup_init(void) err = register_filesystem(&cgroup_fs_type); if (err < 0) - goto out; + return err; proc_create("cgroups", 0, NULL, &proc_cgroupstats_operations); -out: if (err) bdi_destroy(&cgroup_backing_dev_info); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/