Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754250AbYHKOgf (ORCPT ); Mon, 11 Aug 2008 10:36:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751827AbYHKOg1 (ORCPT ); Mon, 11 Aug 2008 10:36:27 -0400 Received: from hrndva-omtalb.mail.rr.com ([71.74.56.122]:34003 "EHLO hrndva-omtalb.mail.rr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751005AbYHKOg0 (ORCPT ); Mon, 11 Aug 2008 10:36:26 -0400 Date: Mon, 11 Aug 2008 10:36:25 -0400 (EDT) From: Steven Rostedt X-X-Sender: rostedt@gandalf.stny.rr.com To: Christoph Lameter cc: Pekka Enberg , Eduard - Gabriel Munteanu , mathieu.desnoyers@polymtl.ca, linux-mm@kvack.org, linux-kernel@vger.kernel.org, rdunlap@xenotime.net, mpm@selenic.com, tglx@linutronix.de Subject: Re: [PATCH 4/5] kmemtrace: SLUB hooks. In-Reply-To: <48A04AEE.8090606@linux-foundation.org> Message-ID: References: <1218388447-5578-1-git-send-email-eduard.munteanu@linux360.ro> <1218388447-5578-2-git-send-email-eduard.munteanu@linux360.ro> <1218388447-5578-3-git-send-email-eduard.munteanu@linux360.ro> <1218388447-5578-4-git-send-email-eduard.munteanu@linux360.ro> <1218388447-5578-5-git-send-email-eduard.munteanu@linux360.ro> <48A046F5.2000505@linux-foundation.org> <1218463774.7813.291.camel@penberg-laptop> <48A048FD.30909@linux-foundation.org> <1218464177.7813.293.camel@penberg-laptop> <48A04AEE.8090606@linux-foundation.org> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1082 Lines: 28 On Mon, 11 Aug 2008, Christoph Lameter wrote: > Pekka Enberg wrote: > > > The function call is supposed to go away when we convert kmemtrace to > > use Mathieu's markers but I suppose even then we have a problem with > > inlining? > > The function calls are overwritten with NOPs? Or how does that work? I believe in the latest version they are just a variable test. But when Mathieu's immediate code makes it in (which it is in linux-tip), we will be overwriting the conditionals with nops (Mathieu, correct me if I'm wrong here). But the calls themselves are done in the unlikely branch. This is important, as Mathieu stated in previous thread. The reason is that all the stack setup for the function call is also in the unlikely branch, and the normal fast path does not take a hit for the function call setup. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/