Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755654AbYHKPui (ORCPT ); Mon, 11 Aug 2008 11:50:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752103AbYHKPua (ORCPT ); Mon, 11 Aug 2008 11:50:30 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:44594 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750852AbYHKPu3 (ORCPT ); Mon, 11 Aug 2008 11:50:29 -0400 Message-ID: <48A05F4D.4080404@linux-foundation.org> Date: Mon, 11 Aug 2008 10:48:29 -0500 From: Christoph Lameter User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) MIME-Version: 1.0 To: "Frank Ch. Eigler" CC: Steven Rostedt , Pekka Enberg , Eduard - Gabriel Munteanu , mathieu.desnoyers@polymtl.ca, linux-mm@kvack.org, linux-kernel@vger.kernel.org, rdunlap@xenotime.net, mpm@selenic.com, tglx@linutronix.de Subject: Re: [PATCH 4/5] kmemtrace: SLUB hooks. References: <1218388447-5578-1-git-send-email-eduard.munteanu@linux360.ro> <1218388447-5578-2-git-send-email-eduard.munteanu@linux360.ro> <1218388447-5578-3-git-send-email-eduard.munteanu@linux360.ro> <1218388447-5578-4-git-send-email-eduard.munteanu@linux360.ro> <1218388447-5578-5-git-send-email-eduard.munteanu@linux360.ro> <48A046F5.2000505@linux-foundation.org> <1218463774.7813.291.camel@penberg-laptop> <48A048FD.30909@linux-foundation.org> <48A04EC2.1080302@linux-foundation.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 980 Lines: 21 Frank Ch. Eigler wrote: > Christoph Lameter writes: > >> [...] >>> There should be no extra function calls when this is configured on but >>> tracing disabled. We try very hard to keep the speed of the tracer as >>> close to a non tracing kernel as possible when tracing is disabled. >> Makes sense. But then we have even more code bloat because of the >> tests that are inserted in all call sites of kmalloc. > > Are you talking about the tests that implement checking whether a > marker is active or not? Those checks are already efficient, and will > get more so with the "immediate values" optimization in or near the > tree. AFAICT: Each test also adds an out of line call to the tracing facility. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/