Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756110AbYHKTWh (ORCPT ); Mon, 11 Aug 2008 15:22:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751780AbYHKTW0 (ORCPT ); Mon, 11 Aug 2008 15:22:26 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:34371 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751760AbYHKTW0 (ORCPT ); Mon, 11 Aug 2008 15:22:26 -0400 Date: Mon, 11 Aug 2008 21:22:03 +0200 From: Ingo Molnar To: Suresh Siddha Cc: Herbert Xu , "H. Peter Anvin" , Wolfgang Walter , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "viro@ZenIV.linux.org.uk" , "vegard.nossum@gmail.com" , Thomas Gleixner Subject: Re: Kernel oops with 2.6.26, padlock and ipsec: probably problem with fpu state changes Message-ID: <20080811192203.GC12788@elte.hu> References: <200807171653.59177.wolfgang.walter@stwm.de> <20080808231121.GA13158@linux-os.sc.intel.com> <20080809143727.GA30499@gondor.apana.org.au> <200808091757.32999.wolfgang.walter@stwm.de> <489DC15D.9070308@zytor.com> <20080809185224.GH13158@linux-os.sc.intel.com> <20080809193724.GJ13158@linux-os.sc.intel.com> <20080810030521.GA2332@gondor.apana.org.au> <20080811190131.GL13158@linux-os.sc.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080811190131.GL13158@linux-os.sc.intel.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 769 Lines: 25 * Suresh Siddha wrote: > Reported-and-bisected-by: Wolfgang Walter > Signed-off-by: Suresh Siddha no fundamental objection to the x86 bits. shouldnt this: + if (!in_interrupt()) + return 0; just be eliminated and the cr0/TS save/restore be made unconditional? irq-assymetric APIs are not nice in general. Reading/setting cr0 isnt _that_ slow. (or if it is, by how much does it slow things down, exactly?) Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/