Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757901AbYHKWE2 (ORCPT ); Mon, 11 Aug 2008 18:04:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752113AbYHKWEU (ORCPT ); Mon, 11 Aug 2008 18:04:20 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:36299 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752074AbYHKWEU (ORCPT ); Mon, 11 Aug 2008 18:04:20 -0400 Date: Mon, 11 Aug 2008 15:03:14 -0700 (PDT) From: Linus Torvalds To: Ingo Molnar cc: Dmitry Adamushko , "Rafael J. Wysocki" , "Langsdorf, Mark" , lkml , Gautham R Shenoy , Peter Zijlstra , Andrew Morton Subject: Re: Regression in 2.6.27-rc1 for set_cpus_allowed_ptr In-Reply-To: <20080811123020.GB10082@elte.hu> Message-ID: References: <6453C3CB8E2B3646B0D020C112613273C5AC5A@sausexmb4.amd.com> <200808082303.41068.rjw@sisk.pl> <20080811123020.GB10082@elte.hu> User-Agent: Alpine 1.10 (LFD 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1366 Lines: 42 On Mon, 11 Aug 2008, Ingo Molnar wrote: > > i've queued up the fix below in tip/sched/urgent. > > diff --git a/kernel/cpu.c b/kernel/cpu.c > index e202a68..c977c33 100644 > --- a/kernel/cpu.c > +++ b/kernel/cpu.c > @@ -349,6 +349,8 @@ static int __cpuinit _cpu_up(unsigned int cpu, int tasks_frozen) > goto out_notify; > BUG_ON(!cpu_online(cpu)); > > + cpu_set(cpu, cpu_active_map); > + > /* Now call notifier in preparation. */ > raw_notifier_call_chain(&cpu_chain, CPU_ONLINE | mod, hcpu); > > @@ -383,9 +385,6 @@ int __cpuinit cpu_up(unsigned int cpu) > > err = _cpu_up(cpu, 0); > > - if (cpu_online(cpu)) > - cpu_set(cpu, cpu_active_map); > - Ok, not only does that fix the bug, but it simplifies the code and looks obviously ok. However, I don't have it in my tree yet, and I'd like to do an -rc3 that has this fixes (so that along with the PCI MSI thing, we hopefully have most of the suspend/resume regressions fixed). And I was hoping to do -rc3 today. Can I please have pull-requests for the appropriate urgent scheduler/x86 fixes? Or should I just take these as patches? Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/