DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=yahoo.com.au;
  h=Received:X-YMail-OSG:X-Yahoo-Newman-Property:From:To:Subject:Date:User-Agent:Cc:References:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-Disposition:Message-Id;
  b=4G9og85YWSboAvHcV9wvYBSZ6WjQiqeStIWzIs3fJEun2TSwR0JSkNrgneOiY25tevsedtFpxxlBH/4BkZNp8wJ+MaRxR81YgtJT9/rGGrdEjHad444AZjfC9REXdsvCJnZVUuQD6z4TIhl/id+d2R45UTjdRqbLZ92IorNBACg=  ;
From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Ryan Hope <rmh3093@gmail.com>
Subject: Re: [PATCH 3/3][reiser4] dont get radix-tree dirty tagging out of sync
Date: Tue, 12 Aug 2008 12:36:51 +1000
User-Agent: KMail/1.9.5
Cc: Andrew Morton <akpm@linux-foundation.org>,
       Edward Shishkin <edward.shishkin@gmail.com>,
       LKML <linux-kernel@vger.kernel.org>,
       Reiserfs mailing list <reiserfs-devel@vger.kernel.org>
References: <48A0BFC9.40502@gmail.com>
In-Reply-To: <48A0BFC9.40502@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200808121236.51599.nickpiggin@yahoo.com.au>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1506
Lines: 39

On Tuesday 12 August 2008 08:40, Ryan Hope wrote:
> This was item #14 on the todo list for reiser4 inclusion in mainline:
>
> diff --git a/fs/reiser4/page_cache.c b/fs/reiser4/page_cache.c
> index fe71368..a662c25 100644
> --- a/fs/reiser4/page_cache.c
> +++ b/fs/reiser4/page_cache.c
> @@ -467,15 +467,14 @@ int reiser4_set_page_dirty_internal(struct page
> *page) BUG_ON(mapping == NULL);
>
>   	if (!TestSetPageDirty(page)) {
> +		spin_lock_irq(&mapping->tree_lock);
>   		if (mapping_cap_account_dirty(mapping))
>   			inc_zone_page_state(page, NR_FILE_DIRTY);
> -
> +		radix_tree_tag_set(&mapping->page_tree,
> +			page_index(page), PAGECACHE_TAG_DIRTY);
>   		__mark_inode_dirty(mapping->host, I_DIRTY_PAGES);
> +		spin_unlock_irq(&mapping->tree_lock);
>   	}
> -
> -	/* znode must be dirty ? */
> -	if (mapping->host == reiser4_get_super_fake(mapping->host->i_sb))
> -		assert("", JF_ISSET(jprivate(page), JNODE_DIRTY));
>   	return 0;
>   }

Any reason why this can't use a generic function such as
__set_page_dirty_nobuffers? There are accounting changes gone in
there now which I suspetc may be wrong now in reiser4 (eg. task
io accounting).

Actually every site that does a radix_tree_operation there should
be reviewed to try to use core functoins.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/