Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752668AbYHLD1x (ORCPT ); Mon, 11 Aug 2008 23:27:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751433AbYHLD1p (ORCPT ); Mon, 11 Aug 2008 23:27:45 -0400 Received: from wolverine01.qualcomm.com ([199.106.114.254]:8131 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751211AbYHLD1p (ORCPT ); Mon, 11 Aug 2008 23:27:45 -0400 X-IronPort-AV: E=McAfee;i="5200,2160,5358"; a="5623722" Message-ID: <48A1032F.4040606@qualcomm.com> Date: Mon, 11 Aug 2008 20:27:43 -0700 From: Max Krasnyansky User-Agent: Thunderbird 2.0.0.14 (X11/20080501) MIME-Version: 1.0 To: Rakib Mullick CC: linux-kernel@vger.kernel.org Subject: Re: [PATCH] cpuset: Rework sched domains and CPU hotplug handling (take 4) References: <1218490433-10576-1-git-send-email-maxk@qualcomm.com> <48A0B16B.2080801@qualcomm.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 853 Lines: 24 Rakib Mullick wrote: > One more thing Max, while you are allocating memory for "dattr" I > think it needs to check that it is successful or not . I've shown it > on one of my previous patch on 7th Aug. I think you missed this part of the patch > + /* > + * The rest of the code, including the scheduler, can deal with > + * dattr==NULL case. No need to abort if alloc fails. > + */ > dattr = kmalloc(ndoms * sizeof(struct sched_domain_attr), GFP_KERNEL); I replied to your patch saying that we do not need to check it. And Paul suggested to add a comment to explain why. Max -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/