Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753198AbYHLM2B (ORCPT ); Tue, 12 Aug 2008 08:28:01 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751978AbYHLM1x (ORCPT ); Tue, 12 Aug 2008 08:27:53 -0400 Received: from palinux.external.hp.com ([192.25.206.14]:57297 "EHLO mail.parisc-linux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751892AbYHLM1x (ORCPT ); Tue, 12 Aug 2008 08:27:53 -0400 Date: Tue, 12 Aug 2008 06:27:51 -0600 From: Matthew Wilcox To: Pekka J Enberg Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, cl@linux-foundation.org Subject: Re: [RFC/PATCH] SLUB: dynamic per-cache MIN_PARTIAL Message-ID: <20080812122751.GY8618@parisc-linux.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1157 Lines: 25 On Tue, Aug 05, 2008 at 12:39:36AM +0300, Pekka J Enberg wrote: > This patch changes the static MIN_PARTIAL to a dynamic per-cache ->min_partial > value that is calculated from object size. The bigger the object size, the more > pages we keep on the partial list. > > I tested SLAB, SLUB, and SLUB with this patch on Jens Axboe's 'netio' example > script of the fio benchmarking tool. The script stresses the networking > subsystem which should also give a fairly good beating of kmalloc() et al. Hi Pekka, We tested this patch and it was performance-neutral on TPC-C. I was hoping it would give a nice improvement ... so I'm disappointed. But at least there's no regression! -- Intel are signing my paycheques ... these opinions are still mine "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/