Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755141AbYHLNsa (ORCPT ); Tue, 12 Aug 2008 09:48:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754187AbYHLNsU (ORCPT ); Tue, 12 Aug 2008 09:48:20 -0400 Received: from nf-out-0910.google.com ([64.233.182.185]:6470 "EHLO nf-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754248AbYHLNsT (ORCPT ); Tue, 12 Aug 2008 09:48:19 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=R0xXmfapm6Dzbj1LYFqdYWdUo71df/KLcnIoaU8rJdhoohyU9CX2EVqWgcoP28u6GE cB1iqQ9LugtNe+9otYYjeg+/NzYUwLZlt6Abj7QPY1a3sN56GzXtUIq9R7Z9lWrOtgJb 48AfxHAzRejnIMzrH3/aCcWa4IBsLMAcPbSUI= Message-ID: Date: Tue, 12 Aug 2008 19:48:17 +0600 From: "Rakib Mullick" To: linux-kernel@vger.kernel.org Subject: Re: [PATCH] cpuset: Rework sched domains and CPU hotplug handling (take 4) In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <1218490433-10576-1-git-send-email-maxk@qualcomm.com> <48A0B16B.2080801@qualcomm.com> <48A1032F.4040606@qualcomm.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1184 Lines: 36 On 8/12/08, Rakib Mullick wrote: > On 8/12/08, Max Krasnyansky wrote: > > > Rakib Mullick wrote: > > > One more thing Max, while you are allocating memory for "dattr" I > > > think it needs to check that it is successful or not . I've shown it > > > on one of my previous patch on 7th Aug. > > > > > > I think you missed this part of the patch > > > > > > > + /* > > > + * The rest of the code, including the scheduler, can deal with > > > + * dattr==NULL case. No need to abort if alloc fails. > > > + */ > > > dattr = kmalloc(ndoms * sizeof(struct sched_domain_attr), GFP_KERNEL); > > > > > > I replied to your patch saying that we do not need to check it. And Paul > > suggested to add a comment to explain why. > Ok, this is the second place. But, what about the first place ( I mean in line 614). > > > > > > Max > > > > > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/