Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754774AbYHLOxM (ORCPT ); Tue, 12 Aug 2008 10:53:12 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752552AbYHLOw5 (ORCPT ); Tue, 12 Aug 2008 10:52:57 -0400 Received: from wa-out-1112.google.com ([209.85.146.181]:65394 "EHLO wa-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752262AbYHLOwz (ORCPT ); Tue, 12 Aug 2008 10:52:55 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=DK+WYUYtFTYjX+VjFlnqJnchQMxiB7DkOJ8t4gl5FgfMRvKvYsuQ2KQpin3NNUHbk/ qFSK3j6A+IXVQqgB1Z72NaGw3fVYDGZG47xzr3pL4Kbi2XPAbeLDpb3ppShm8y15w33J XR4XnshqpTblvlbM4ugNqbeHmMJUWNIv7p6OI= Message-ID: <48f7fe350808120752ud51183xeb870558d196c5fd@mail.gmail.com> Date: Tue, 12 Aug 2008 10:52:53 -0400 From: "Ryan Hope" To: "Nick Piggin" Subject: Re: [PATCH 3/3][reiser4] dont get radix-tree dirty tagging out of sync Cc: "Andrew Morton" , "Edward Shishkin" , LKML , "Reiserfs mailing list" In-Reply-To: <200808121600.40293.nickpiggin@yahoo.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <48A0BFC9.40502@gmail.com> <200808121236.51599.nickpiggin@yahoo.com.au> <48f7fe350808112112k5e92330epa8345cbe4eb4c1b5@mail.gmail.com> <200808121600.40293.nickpiggin@yahoo.com.au> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2409 Lines: 54 On Tue, Aug 12, 2008 at 2:00 AM, Nick Piggin wrote: > On Tuesday 12 August 2008 14:12, Ryan Hope wrote: >> I tried just using __set_page_dirty_nobuffers but that caused issues >> with ext3/ext4 (i can send a bug trace later if needed). >> >> __inc_bdi_stat(mapping->backing_dev_info, >> BDI_RECLAIMABLE); >> task_io_account_write(PAGE_CACHE_SIZE); >> >> ^^^ the above code in __set_page_dirty_nobuffers causes an issue with >> do_writepages in ext3/4 when I use something like the code below: >> >> int reiser4_set_page_dirty_internal(struct page *page) >> { >> return __set_page_dirty_nobuffers(page); >> } > > Hmm, it causes issues in ext3/4 even though it doesn't change any > code executed by ext3/4? Yes, if you could send a trace... > Pid: 2620, comm: bonnie Not tainted 2.6.27-rc2-zen1 #1 [] do_writepages+0x49/0x50 [] ext3_write_inode+0x0/0x40 [] ext3_write_inode+0x30/0x40 [] __writeback_single_inode+0x282/0x390 [] generic_sync_sb_inodes+0x304/0x3a0 [] reiser4_sync_inodes+0x54/0x130 [reiser4] [] generic_sync_sb_inodes+0x270/0x3a0 [] writeback_inodes+0x44/0xd0 [] balance_dirty_pages_ratelimited_nr+0x230/0x370 [] reiser4_txn_end+0x4ec/0xae0 [reiser4] [] balance_dirty_page_cluster+0x10a/0x1b0 [reiser4] [] write_cryptcompress+0x610/0xdf0 [reiser4] [] reiser4_write_careful+0xb6/0x880 [reiser4] [] update_curr+0x4e/0x70 [] task_tick_fair+0x32/0x90 [] hrtimer_forward+0xf7/0x150 [] getnstimeofday+0x43/0xf0 [] clockevents_program_event+0xa5/0x160 [] run_timer_softirq+0x146/0x1c0 [] tick_program_event+0x3a/0x70 [] security_file_permission+0xc/0x10 [] rw_verify_area+0x4a/0xc0 [] reiser4_write_careful+0x0/0x880 [reiser4] [] vfs_write+0xa0/0x140 [] sys_write+0x41/0x80 [] sysenter_do_call+0x12/0x25 ======================= -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/