Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754467AbYHLPnu (ORCPT ); Tue, 12 Aug 2008 11:43:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753669AbYHLPnj (ORCPT ); Tue, 12 Aug 2008 11:43:39 -0400 Received: from tomts5-srv.bellnexxia.net ([209.226.175.25]:38162 "EHLO tomts5-srv.bellnexxia.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753493AbYHLPni (ORCPT ); Tue, 12 Aug 2008 11:43:38 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApsEAGVMoUhMRKxB/2dsb2JhbACBYK4WgSk Date: Tue, 12 Aug 2008 11:43:34 -0400 From: Mathieu Desnoyers To: Eduard - Gabriel Munteanu Cc: Pekka Enberg , Christoph Lameter , linux-mm@kvack.org, linux-kernel@vger.kernel.org, rdunlap@xenotime.net, mpm@selenic.com, rostedt@goodmis.org, tglx@linutronix.de Subject: Re: [PATCH 4/5] kmemtrace: SLUB hooks. Message-ID: <20080812154334.GA18581@Krystal> References: <1218388447-5578-3-git-send-email-eduard.munteanu@linux360.ro> <1218388447-5578-4-git-send-email-eduard.munteanu@linux360.ro> <1218388447-5578-5-git-send-email-eduard.munteanu@linux360.ro> <48A046F5.2000505@linux-foundation.org> <1218463774.7813.291.camel@penberg-laptop> <48A048FD.30909@linux-foundation.org> <1218464177.7813.293.camel@penberg-laptop> <48A04AEE.8090606@linux-foundation.org> <1218464557.7813.295.camel@penberg-laptop> <20080812152954.GB5973@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline In-Reply-To: <20080812152954.GB5973@localhost> X-Editor: vi X-Info: http://krystal.dyndns.org:8080 X-Operating-System: Linux/2.6.21.3-grsec (i686) X-Uptime: 11:39:53 up 68 days, 20:20, 7 users, load average: 0.65, 0.54, 0.55 User-Agent: Mutt/1.5.16 (2007-06-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1343 Lines: 35 * Eduard - Gabriel Munteanu (eduard.munteanu@linux360.ro) wrote: > On Mon, Aug 11, 2008 at 05:22:37PM +0300, Pekka Enberg wrote: > > On Mon, 2008-08-11 at 09:21 -0500, Christoph Lameter wrote: > > > Pekka Enberg wrote: > > > > > > > The function call is supposed to go away when we convert kmemtrace to > > > > use Mathieu's markers but I suppose even then we have a problem with > > > > inlining? > > > > > > The function calls are overwritten with NOPs? Or how does that work? > > > > I have no idea. Mathieu, Eduard? > > Yes, the code is patched at runtime. But AFAIK markers already provide > this stuff (called "immediate values"). Mathieu's tracepoints also do > it. But it's not available on all arches. x86 and x86-64 work as far as > I remember. > The markers present in mainline kernel does not use immediate values. However, immediate values in tip does implement a load immediate/test/branch for x86, x86_64 and powerpc. I also have support for sparc64 in my lttng tree. Mathieu -- Mathieu Desnoyers OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/