Date: Tue, 12 Aug 2008 20:24:56 +0200
From: Joerg Roedel <joro@8bytes.org>
To: Joerg Roedel <joerg.roedel@amd.com>
Cc: mingo@redhat.com, tglx@linutronix.de, hpa@zytor.com,
       linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
       muli@il.ibm.com
Subject: Re: [PATCH 4/7] x86: add alloc_coherent dma_ops callback to NOMMU driver
Message-ID: <20080812182455.GD4342@8bytes.org>
References: <1218554657-16070-1-git-send-email-joerg.roedel@amd.com> <1218554657-16070-5-git-send-email-joerg.roedel@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1218554657-16070-5-git-send-email-joerg.roedel@amd.com>
User-Agent: Mutt/1.5.13 (2006-08-11)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 931
Lines: 34

On Tue, Aug 12, 2008 at 05:24:14PM +0200, Joerg Roedel wrote:
> +static void *
> +nommu_alloc_coherent(struct device *hwdev, size_t size,
> +		     dma_addr_t *dma_addr, gfp_t gfp)
> +{
> +	unsigned long dma_mask;
> +	int node;
> +	struct page *page;
> +
> +	if (hwdev->dma_mask == NULL)
> +		return NULL;
> +
> +	gfp &= ~(__GFP_DMA | __GFP_HIGHMEM | __GFP_DMA32);
> +	gfp |= __GFP_ZERO;
> +
> +	dma_mask = hwdev->coherent_dma_mask;
> +	if (!dma_mask)
> +		dma_mask = *(hwdev->dma_mask);
> +
> +	if (dma_mask <= DMA_24BIT_MASK)
> +		gfp |= GFP_DMA;
> +	else if (dma_mask <= DMA_32BIT_MASK)
> +		gfp |= GFP_DMA32;

Argh. But there is a bug in this logic :-(
I fix it and resend.

Joerg

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/