Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753723AbYHLTZg (ORCPT ); Tue, 12 Aug 2008 15:25:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752108AbYHLTZQ (ORCPT ); Tue, 12 Aug 2008 15:25:16 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:43400 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752081AbYHLTZO (ORCPT ); Tue, 12 Aug 2008 15:25:14 -0400 Date: Tue, 12 Aug 2008 15:25:11 -0400 From: Christoph Hellwig To: Mimi Zohar Cc: Christoph Hellwig , linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, Al Viro , Stephen Smalley , James Morris , Randy Dunlap , safford@watson.ibm.com, serue@linux.vnet.ibm.com, sailer@watson.ibm.com, Mimi Zohar Subject: Re: [PATCH 3/4] integrity: Linux Integrity Module(LIM) Message-ID: <20080812192511.GA18034@infradead.org> References: <20080808184349.999902616@linux.vnet.ibm.com> <1218221761.4444.13.camel@localhost.localdomain> <20080809185340.GC22905@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 981 Lines: 19 On Sun, Aug 10, 2008 at 09:52:13AM -0400, Mimi Zohar wrote: > We started out with the integrity_inode_permission() hook call in > inode_permission(), but because of the removal of the nameidata > parameter in the last merge, based on discussions > http://marc.info/?l=linux-security-module&m=121797845308246&w=2, > the call to integrity_inode_permission() was moved up to the caller, > where either a file or path are available. Any suggestions? vfs_permission and file_permission are just small wrappers around inode_permission. In hindsight they actualyl were a wrong idea and will probably go away in the not so distant future. Note that there are various callers of inode_permission that don't have a vfsmount anywhere near. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/