From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Marcin Slusarz <marcin.slusarz@gmail.com>
Subject: Re: [PATCH] suspend: fix section mismatch warning - register_nosave_region
Date: Tue, 12 Aug 2008 23:49:25 +0200
User-Agent: KMail/1.9.6 (enterprise 20070904.708012)
Cc: LKML <linux-kernel@vger.kernel.org>, Pavel Machek <pavel@suse.cz>,
       Len Brown <len.brown@intel.com>, Andrew Morton <akpm@google.com>
References: <1218576186-31442-4-git-send-email-marcin.slusarz@gmail.com>
In-Reply-To: <1218576186-31442-4-git-send-email-marcin.slusarz@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200808122349.26256.rjw@sisk.pl>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1905
Lines: 45

On Tuesday, 12 of August 2008, Marcin Slusarz wrote:
> WARNING: vmlinux.o(.text+0xe684): Section mismatch in reference from the function register_nosave_region() to the function .init.text:__register_nosave_region()
> The function register_nosave_region() references
> the function __init __register_nosave_region().
> This is often because register_nosave_region lacks a __init
> annotation or the annotation of __register_nosave_region is wrong.
> 
> register_nosave_region calls __init function and is called only from __init functions
> 
> Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
> Cc: Rafael J. Wysocki <rjw@sisk.pl>
> Cc: Pavel Machek <pavel@suse.cz>
> Cc: Len Brown <len.brown@intel.com>

Acked-by: Rafael J. Wysocki <rjw@sisk.pl>

> ---
>  include/linux/suspend.h |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/suspend.h b/include/linux/suspend.h
> index c634350..2ce8207 100644
> --- a/include/linux/suspend.h
> +++ b/include/linux/suspend.h
> @@ -217,11 +217,11 @@ struct platform_hibernation_ops {
>  #ifdef CONFIG_HIBERNATION
>  /* kernel/power/snapshot.c */
>  extern void __register_nosave_region(unsigned long b, unsigned long e, int km);
> -static inline void register_nosave_region(unsigned long b, unsigned long e)
> +static inline void __init register_nosave_region(unsigned long b, unsigned long e)
>  {
>  	__register_nosave_region(b, e, 0);
>  }
> -static inline void register_nosave_region_late(unsigned long b, unsigned long e)
> +static inline void __init register_nosave_region_late(unsigned long b, unsigned long e)
>  {
>  	__register_nosave_region(b, e, 1);
>  }


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/