Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754836AbYHLWGT (ORCPT ); Tue, 12 Aug 2008 18:06:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751351AbYHLWGG (ORCPT ); Tue, 12 Aug 2008 18:06:06 -0400 Received: from gprs189-60.eurotel.cz ([160.218.189.60]:38249 "EHLO gprs189-60.eurotel.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751457AbYHLWGD (ORCPT ); Tue, 12 Aug 2008 18:06:03 -0400 Date: Wed, 13 Aug 2008 00:07:22 +0200 From: Pavel Machek To: "Langsdorf, Mark" Cc: Greg KH , "Deguara, Joachim" , tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 01/01][retry 1] x86: L3 cache index disable for 2.6.26 Message-ID: <20080812220722.GE12911@elf.ucw.cz> References: <200807181603.52332.mark.langsdorf@amd.com> <20080808220011.GA12156@ucw.cz> <200808121104.09288.mark.langsdorf@amd.com> <20080812215659.GA12911@elf.ucw.cz> <6453C3CB8E2B3646B0D020C112613273C5AC68@sausexmb4.amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6453C3CB8E2B3646B0D020C112613273C5AC68@sausexmb4.amd.com> X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1216 Lines: 38 > > > + for (i = 0; i < 2; i++) { > > > + unsigned int reg = 0; > > > + > > > + pci_read_config_dword(dev, 0x1BC + i * 4, ®); > > > + > > > + ret += sprintf(buf, "%s %x\t", buf, reg); > > > + } > > > + ret += sprintf(buf,"%s\n", buf); > > > > So you print "buf" few times? Why? And you use both \t and \n > > as deliminer... > > I'm printing the values of the two config registers into > the string buffer, separated by tabs, and terminated by > an EOL. Is there a prefered way to do that instead of > what I have? Hmm, I misparsed that. Yes, we have some helpers for sysfs writing... SEQ_printf(), IIRC. Is this even valid C? ret += sprintf(buf, "%s %x\t", buf, reg); You are printing into buffer you are passing as argument. That seems fragile. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/