Date: Wed, 13 Aug 2008 09:52:36 +0200
From: Ingo Molnar <mingo@elte.hu>
To: Shaohua Li <shaohua.li@intel.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
       Andrew Morton <akpm@linux-foundation.org>,
       Arjan van de Ven <arjan@infradead.org>
Subject: Re: [patch]fastboot: remove duplicate unpack_to_rootfs()
Message-ID: <20080813075236.GA8052@elte.hu>
References: <1218607669.3463.9.camel@sli10-desk.sh.intel.com> <20080813074503.GB398@elte.hu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20080813074503.GB398@elte.hu>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1542
Lines: 62


* Ingo Molnar <mingo@elte.hu> wrote:

> the dry_run variable is now unused in unpack_to_rootfs() and could be 
> eliminated.

also, while we are materially touching init/initramfs.c, that file has 
collected a few uglies in the past few years, checkpatch --file says:

  total: 7 errors, 7 warnings, 3 checks, 562 lines checked

it has a few other problems as well that can be seen if you look at the 
file. Unused macros:

 /* Diagnostic functions (stubbed out) */
 #define Assert(cond,msg)
 #define Trace(x)
 #define Tracev(x)
 #define Tracevv(x)
 #define Tracec(c,x)
 #define Tracecv(c,x)

 #define STATIC static
 #define INIT __init

lots of no-newline-after-variable-definitions instances:

 {
         int written;
         dry_run = check_only;

no-newline-before-return:

         kfree(header_buf);
         return message;
 }

so it would be nice to start off with a cleanup [strictly no code 
changed] patch.

then it also has an absolutely crazy turn-error-printouts-off hack:

 static __initdata char *message;
 static void __init error(char *x)
 {
         if (!message)
                 message = x;
 }

which is unobvious, 100% unused and should be removed.

those error()s should be pr_debug() perhaps. [this should be a second 
cleanup patch as it changes the code]

Hm?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/