Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754478AbYHMJST (ORCPT ); Wed, 13 Aug 2008 05:18:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752223AbYHMJSJ (ORCPT ); Wed, 13 Aug 2008 05:18:09 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:60658 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752347AbYHMJSI (ORCPT ); Wed, 13 Aug 2008 05:18:08 -0400 Date: Wed, 13 Aug 2008 11:17:41 +0200 From: Ingo Molnar To: Johannes Weiner Cc: Jan Beulich , Linus Torvalds , dhowells@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Propagate new nonpanic bootmem macros to CONFIG_HAVE_ARCH_BOOTMEM_NODE Message-ID: <20080813091741.GJ23417@elte.hu> References: <87skt99vmz.fsf@skyscraper.fehenstaub.lan> <48A2B7BA.76E4.0078.0@novell.com> <20080813085509.GC23417@elte.hu> <87k5el9tb6.fsf@skyscraper.fehenstaub.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87k5el9tb6.fsf@skyscraper.fehenstaub.lan> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1680 Lines: 46 * Johannes Weiner wrote: > Hi Ingo, > > Ingo Molnar writes: > > > * Jan Beulich wrote: > > > >> Sorry for not noticing this: > >> Acked-by: Jan Beulich > >> > >> >>> Johannes Weiner 13.08.08 10:17 >>> > >> Commit 74768ed833344b "page allocator: use no-panic variant of > >> alloc_bootmem() in alloc_large_system_hash()" introduced two new > >> _nopanic macros which are undefined for CONFIG_HAVE_ARCH_BOOTMEM_NODE. > >> > >> Signed-off-by: Johannes Weiner > > > > btw., i dont think the fix is complete, a quick grep shows: > > > > arch/avr32/Kconfig:config HAVE_ARCH_BOOTMEM_NODE > > Uhm, I think a fix for that would be removing the knob from the avr32 > Kconfig. It defaults to n and I couldn't find a place where this gets > enabled. > > Furthermore, there doesn't seem to be any arch-specific code > associated with it (grep -R ARCH_BOOTMEM_NODE arch/avr32). ok, indeed. I dont think it should be removed: it makes sense for an architecture to list all Kconfig knobs that _might_ matter - even if they are disabled for an architecture. That makes it easier to know whether a Kconfig knob that is disables is disabled because the arch wants it disabled, because the arch wants it enabled, or because it's a knew knob the arch does not know about yet. So it's 3 states really. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/