Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755364AbYHMNhb (ORCPT ); Wed, 13 Aug 2008 09:37:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751182AbYHMNhT (ORCPT ); Wed, 13 Aug 2008 09:37:19 -0400 Received: from cantor2.suse.de ([195.135.220.15]:49505 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751457AbYHMNhR (ORCPT ); Wed, 13 Aug 2008 09:37:17 -0400 Date: Wed, 13 Aug 2008 15:37:15 +0200 Message-ID: From: Takashi Iwai To: Alan Cox Cc: Stephen Rothwell , linux-next@vger.kernel.org, LKML Subject: Re: linux-next: Tree for August 13 In-Reply-To: <20080813140811.030bb766@lxorguk.ukuu.org.uk> References: <20080813172452.14b0775c.sfr@canb.auug.org.au> <20080813140811.030bb766@lxorguk.ukuu.org.uk> User-Agent: Wanderlust/2.12.0 (Your Wildest Dreams) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/22.2 (x86_64-suse-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1131 Lines: 41 At Wed, 13 Aug 2008 14:08:11 +0100, Alan Cox wrote: > > > When re-starting X, it complains that it cannot change to VT7. > > Via strace, > > Does this fix it > > @@ -838,6 +839,7 @@ static int copy_signal(unsigned long clone_flags, struct task_struct *tsk) > void __cleanup_signal(struct signal_struct *sig) > { > exit_thread_group_keys(sig); > + tty_kref_put(sig->tty); > kmem_cache_free(signal_cachep, sig); > } Thanks, will give it a try. The above can't be applied as is to next tree, so the following is applied instead. Takashi --- diff --git a/kernel/fork.c b/kernel/fork.c index 600a264..2353660 100644 --- a/kernel/fork.c +++ b/kernel/fork.c @@ -834,6 +834,7 @@ static int copy_signal(unsigned long clone_flags, struct task_struct *tsk) void __cleanup_signal(struct signal_struct *sig) { + tty_kref_put(sig->tty); kmem_cache_free(signal_cachep, sig); } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/