Date: Wed, 13 Aug 2008 11:42:29 -0700
From: Arjan van de Ven <arjan@infradead.org>
To: Mark Langsdorf <mark.langsdorf@amd.com>
Cc: Ingo Molnar <mingo@elte.hu>,
       Linus Torvalds <torvalds@linux-foundation.org>,
       linux-kernel@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
       Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH](retry 2) Re: invalidate caches before going into
 suspend
Message-ID: <20080813114229.118be446@infradead.org>
In-Reply-To: <200808131333.17850.mark.langsdorf@amd.com>
References: <200808131141.18003.mark.langsdorf@amd.com>
	<200808131230.07581.mark.langsdorf@amd.com>
	<20080813175232.GA1127@elte.hu>
	<200808131333.17850.mark.langsdorf@amd.com>
Organization: Intel
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 914
Lines: 25

On Wed, 13 Aug 2008 13:33:17 -0500
Mark Langsdorf <mark.langsdorf@amd.com> wrote:
> +	/* mask all interrupts, flush any and all caches, and halt */
> +	if (cpu_has_clflush)
> +		wbinvd_halt();
> +	else
> +		while (1)
> +			halt();
>  }

I like the asm version .. but this code makes me blink.
when you HAVE clflush you do wbinvd.
yeah I know it's correct but... it reads wonky ;)
also.. can we move that check into the wbinvd_halt() itself, so that
the callers don't need to care what is used to select it ?

-- 
If you want to reach me at my work email, use arjan@linux.intel.com
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/