Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755305AbYHMTsa (ORCPT ); Wed, 13 Aug 2008 15:48:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751932AbYHMTsW (ORCPT ); Wed, 13 Aug 2008 15:48:22 -0400 Received: from nf-out-0910.google.com ([64.233.182.185]:63957 "EHLO nf-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751861AbYHMTsV (ORCPT ); Wed, 13 Aug 2008 15:48:21 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references:x-google-sender-auth; b=GsrYBn1vLNjKVsLUJXyYj8hC8R4CuRuqsUMQimN3luSpPaUpkGSHDs7O0n5GZWeXzF 1Rgm4+I0t0ysyLBCCPkjLmcPmIsWC7yPVIfYSz5gHx6W71o33pfNPTpa1U9zVS+BnPn2 zWkNm7ZLvaUbegdYHm9+e6SkpFdkjUAjme8Lw= Message-ID: Date: Wed, 13 Aug 2008 20:48:19 +0100 From: "Marcin Obara" To: "Greg KH" Subject: Re: [PATCH] Intel Management Engine Interface Cc: linux-kernel@vger.kernel.org In-Reply-To: <20080813181850.GD4886@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080813005835.GE22793@kroah.com> <20080813181850.GD4886@kroah.com> X-Google-Sender-Auth: 9f8cdefdc17241de Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1234 Lines: 35 2008/8/13 Greg KH : >> GET_VERSION is called frequently > > Why? Shouldn't it only be called once? Once per connection. But you can have many clients connecting. >> With ioctl - only one file handle is used, and userspace client logic >> is simpler. > > But the kernel is messier and we are trying to not add any more ioctls > to it. Especially for trivial things like the version number of the > hardware device. It's rather protocol version (=running software version) supported by hardware device. Hmmm, I just didn't know that there is something wrong with ioctls. >> Normal flow looks like: >> >> open >> ioctl(GET_VERSION) > > Great, do an additional open/read/close here for the version, I think > you will find it pretty trivial to do :) Right, it's trivial.... but will make userspace source code messier and bigger. Btw. I know we have powerful CPUs... but small wasting resources is still wasting resources... so we still need new CPUs :-). Regards Marcin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/