Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758190AbYHNIpX (ORCPT ); Thu, 14 Aug 2008 04:45:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753779AbYHNIpE (ORCPT ); Thu, 14 Aug 2008 04:45:04 -0400 Received: from srv5.dvmed.net ([207.36.208.214]:36254 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754922AbYHNIpB (ORCPT ); Thu, 14 Aug 2008 04:45:01 -0400 Message-ID: <48A3F07E.8000808@garzik.org> Date: Thu, 14 Aug 2008 04:44:46 -0400 From: Jeff Garzik User-Agent: Thunderbird 2.0.0.16 (X11/20080723) MIME-Version: 1.0 To: roel kluin CC: jie.yang@atheros.com, jgarzik@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH?] atl1e: WAKE_MCAST 2x. 1st WAKE_UCAST? References: <489B21CA.7010508@gmail.com> In-Reply-To: <489B21CA.7010508@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.4 (----) X-Spam-Report: SpamAssassin version 3.2.5 on srv5.dvmed.net summary: Content analysis details: (-4.4 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1024 Lines: 27 roel kluin wrote: > untested, is it right? > --- > WAKE_MCAST bit tested twice, test WAKE_UCAST first. > > Signed-off-by: Roel Kluin > diff --git a/drivers/net/atl1e/atl1e_ethtool.c b/drivers/net/atl1e/atl1e_ethtool.c > index cdc3b85..619c658 100644 > --- a/drivers/net/atl1e/atl1e_ethtool.c > +++ b/drivers/net/atl1e/atl1e_ethtool.c > @@ -355,7 +355,7 @@ static int atl1e_set_wol(struct net_device *netdev, struct ethtool_wolinfo *wol) > struct atl1e_adapter *adapter = netdev_priv(netdev); > > if (wol->wolopts & (WAKE_ARP | WAKE_MAGICSECURE | > - WAKE_MCAST | WAKE_BCAST | WAKE_MCAST)) > + WAKE_UCAST | WAKE_MCAST | WAKE_BCAST)) > return -EOPNOTSUPP; > /* these settings will always override what we currently have */ applied -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/