Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754841AbYHNO72 (ORCPT ); Thu, 14 Aug 2008 10:59:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751272AbYHNO7U (ORCPT ); Thu, 14 Aug 2008 10:59:20 -0400 Received: from 166-70-238-42.ip.xmission.com ([166.70.238.42]:60492 "EHLO ns1.wolfmountaingroup.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751182AbYHNO7U (ORCPT ); Thu, 14 Aug 2008 10:59:20 -0400 Message-ID: <44303.166.70.238.45.1218724556.squirrel@webmail.wolfmountaingroup.com> In-Reply-To: <84144f020808140139v691e6590idd79995168af4e9e@mail.gmail.com> References: <200808140614.m7E6EcDS006264@wolfmountaingroup.com> <84144f020808140139v691e6590idd79995168af4e9e@mail.gmail.com> Date: Thu, 14 Aug 2008 08:35:56 -0600 (MDT) Subject: Re: [PATCH 2.6.27-rc3 26/29] mdb: export task_curr From: jmerkey@wolfmountaingroup.com To: "Pekka Enberg" Cc: jmerkey@wolfmountaingroup.com, linux-kernel@vger.kernel.org, "Ingo Molnar" User-Agent: SquirrelMail/1.4.6 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Priority: 3 (Normal) Importance: Normal Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1066 Lines: 33 > On Thu, Aug 14, 2008 at 9:14 AM, wrote: >> export the task_curr function to the module based kernel debugger to >> enable >> process back tracing and state display. >> >> Signed-off-by: Jeffrey Vernon Merkey (jmerkey@wolfmountaingroup.com) >> >> --- a/kernel/sched.c 2008-08-13 14:22:32.000000000 -0600 >> +++ b/kernel/sched.c 2008-08-13 11:56:03.000000000 -0600 >> @@ -1736,6 +1736,9 @@ >> { >> return cpu_curr(task_cpu(p)) == p; >> } >> +#if defined(CONFIG_MDB_MODULE) >> +EXPORT_SYMBOL_GPL(task_curr); >> +#endif > > We usually don't export symbols conditionally, especially in core kernel > code. > Well,then please suggest how a kernel debugger can be module based and still be able to get this information some other way that's generic and minimal impact. Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/