Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755962AbYHOMNE (ORCPT ); Fri, 15 Aug 2008 08:13:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752921AbYHOMMx (ORCPT ); Fri, 15 Aug 2008 08:12:53 -0400 Received: from gv-out-0910.google.com ([216.239.58.188]:16870 "EHLO gv-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752662AbYHOMMx (ORCPT ); Fri, 15 Aug 2008 08:12:53 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=CNQ5rjg/OeHYi2J5CKsQtVGdmqo/pSWKcaMzN+9xIJxYpNqQ5HpGMHeLYoml/Qllto ac7uk3vTM5LOhbfCWlze5Ce7WTCJneBZO/9VVoT0MyREqfleIWmaSoI0fcxf04lylXom EcEArZ1psvikbGKaSSPpUoqEYUwtGRRSETu5k= Date: Fri, 15 Aug 2008 14:12:17 +0200 From: Marcin Slusarz To: Pavel Machek Cc: Sven Wegener , LKML , Glauber Costa , Ingo Molnar Subject: Re: [PATCH] x86, acpi: temp_stack is used only when CONFIG_SMP is set Message-ID: <20080815121213.GA5285@joi> References: <20080803165210.GC5414@joi> <20080803172535.GE5414@joi> <20080807081245.GA1647@elf.ucw.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080807081245.GA1647@elf.ucw.cz> User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2082 Lines: 55 On Thu, Aug 07, 2008 at 10:12:46AM +0200, Pavel Machek wrote: > Hi! > > > > > arch/x86/kernel/acpi/sleep.c:24: warning: 'temp_stack' defined but not used > > > > > > > > Signed-off-by: Marcin Slusarz > > > > Cc: Glauber Costa > > > > Cc: Pavel Machek > > > > Cc: Ingo Molnar > > > > --- > > > > arch/x86/kernel/acpi/sleep.c | 2 +- > > > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > > > > > diff --git a/arch/x86/kernel/acpi/sleep.c b/arch/x86/kernel/acpi/sleep.c > > > > index fa2161d..9103cb6 100644 > > > > --- a/arch/x86/kernel/acpi/sleep.c > > > > +++ b/arch/x86/kernel/acpi/sleep.c > > > > @@ -20,7 +20,7 @@ unsigned long acpi_realmode_flags; > > > > /* address in low memory of the wakeup routine. */ > > > > static unsigned long acpi_realmode; > > > > > > > > -#ifdef CONFIG_64BIT > > > > +#ifdef CONFIG_SMP > > > > static char temp_stack[10240]; > > > > #endif > > > > > > > > > > Now it still generates the warning, but on i386 with CONFIG_SMP set, > > > instead of x86_64 without CONFIG_SMP. We only need temp_stack, when both > > > CONFIG_64BIT and CONFIG_SMP are activated. > > > > Yes. Thanks for looking at the patch! > > > > --- > > From c6e673acf02e8bf04866cadf17c1cb1fa4d852ea Mon Sep 17 00:00:00 2001 > > From: Marcin Slusarz > > Subject: [PATCH] x86, acpi: temp_stack is used only when CONFIG_64BIT && CONFIG_SMP is set > > > > arch/x86/kernel/acpi/sleep.c:24: warning: 'temp_stack' defined but not used > > > > Signed-off-by: Marcin Slusarz > > Cc: Glauber Costa > > Acked-by: Pavel Machek > > Ingo, can you merge this one? Should I resend this patch? Or is there anything wrong with second version? Marcin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/