Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754828AbYHPD1S (ORCPT ); Fri, 15 Aug 2008 23:27:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751558AbYHPD1F (ORCPT ); Fri, 15 Aug 2008 23:27:05 -0400 Received: from terminus.zytor.com ([198.137.202.10]:60208 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751444AbYHPD1E convert rfc822-to-8bit (ORCPT ); Fri, 15 Aug 2008 23:27:04 -0400 Message-Id: <200808160326.m7G3QR1G012726@terminus.zytor.com> MIME-Version: 1.0 content-class: From: "H. Peter Anvin" Subject: RE: [PATCH] pci: change msi-x vector to 32bit Date: Fri, 15 Aug 2008 20:26:33 -0700 Importance: normal X-Priority: 3 To: Yinghai Lu , Jesse Barnes , James Bottomley , Ingo Molnar , Thomas Gleixner , "Eric W. Biederman" , Andrew Morton CC: , Andrew Vasquez Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2144 Lines: 58 The 28 bits aren't enough, are they: we need domain as well (and surely we can have more than 16 domains?) -hpa -- Sent from my mobile phone (pardon any lack of formatting) -----Original Message----- From: Yinghai Lu Sent: Friday, August 15, 2008 19:36 To: Jesse Barnes ; James Bottomley ; Ingo Molnar ; Thomas Gleixner ; H. Peter Anvin ; Eric W. Biederman ; Andrew Morton Cc: linux-kernel@vger.kernel.org; Yinghai Lu ; Andrew Vasquez Subject: [PATCH] pci: change msi-x vector to 32bit we are using 28bit pci (bus/dev/fn + 12 bits) as irq number, so the cache for irq number should be 32 bit too. Signed-off-by: Yinghai Lu Cc: Andrew Vasquez --- drivers/scsi/qla2xxx/qla_def.h | 2 +- include/linux/pci.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Index: linux-2.6/drivers/scsi/qla2xxx/qla_def.h =================================================================== --- linux-2.6.orig/drivers/scsi/qla2xxx/qla_def.h +++ linux-2.6/drivers/scsi/qla2xxx/qla_def.h @@ -2109,7 +2109,7 @@ struct scsi_qla_host; struct qla_msix_entry { int have_irq; - uint16_t msix_vector; + uint32_t msix_vector; uint16_t msix_entry; }; Index: linux-2.6/include/linux/pci.h =================================================================== --- linux-2.6.orig/include/linux/pci.h +++ linux-2.6/include/linux/pci.h @@ -730,7 +730,7 @@ enum pci_dma_burst_strategy { }; struct msix_entry { - u16 vector; /* kernel uses to write allocated vector */ + u32 vector; /* kernel uses to write allocated vector */ u16 entry; /* driver uses to specify entry, OS writes */ }; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/