Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754338AbYHPGej (ORCPT ); Sat, 16 Aug 2008 02:34:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752130AbYHPGeb (ORCPT ); Sat, 16 Aug 2008 02:34:31 -0400 Received: from one.firstfloor.org ([213.235.205.2]:48191 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751170AbYHPGeb (ORCPT ); Sat, 16 Aug 2008 02:34:31 -0400 To: jmerkey@wolfmountaingroup.com Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 2.6.27-rc3 21/28] mdb: disable console warnings if the debugger is present. From: Andi Kleen References: <200808160341.m7G3flG1022571@wolfmountaingroup.com> Date: Sat, 16 Aug 2008 08:34:28 +0200 In-Reply-To: <200808160341.m7G3flG1022571@wolfmountaingroup.com> (jmerkey@wolfmountaingroup.com's message of "Fri, 15 Aug 2008 21:41:47 -0600") Message-ID: <87ljyxxybv.fsf@basil.nowhere.org> User-Agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/21.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 738 Lines: 23 jmerkey@wolfmountaingroup.com writes: > > /* Some debug stub to catch some of the obvious races in the VT code */ > + > +#if defined(CONFIG_MDB) || defined(CONFIG_MDB_MODULE) > +#define WARN_CONSOLE_UNLOCKED() > +#else > #if 1 > #define WARN_CONSOLE_UNLOCKED() WARN_ON(!is_console_locked() && !oops_in_progress) > #else > #define WARN_CONSOLE_UNLOCKED() > #endif > +#endif /* CONFIG_MDB */ The obvious alternative would be to just set oops_in_progress while the debugger runs. -Andi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/