Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753428AbYHPRp2 (ORCPT ); Sat, 16 Aug 2008 13:45:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752105AbYHPRpO (ORCPT ); Sat, 16 Aug 2008 13:45:14 -0400 Received: from mtagate4.de.ibm.com ([195.212.29.153]:45788 "EHLO mtagate4.de.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751500AbYHPRpN (ORCPT ); Sat, 16 Aug 2008 13:45:13 -0400 Subject: Re: [patch 1/3] kmsg: Kernel message catalog macros. From: Martin Schwidefsky Reply-To: schwidefsky@de.ibm.com To: Rick Troth Cc: Rusty Russell , linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, lf_kernel_messages@lists.linux-foundation.org, Andrew Morton , Michael Holzheu , Gerrit Huizenga , Greg Kroah-Hartman , Randy Dunlap , Jan Kara , Pavel Machek , Sam Ravnborg , Joe Perches , Jochen =?ISO-8859-1?Q?Vo=DF?= , Kunai Takashi , Tim Bird In-Reply-To: References: <20080730165656.118280544@de.ibm.com> <20080730171156.824640459@de.ibm.com> <200808131433.02966.rusty@rustcorp.com.au> Content-Type: text/plain Organization: IBM Corporation Date: Sat, 16 Aug 2008 19:45:05 +0200 Message-Id: <1218908705.6037.6.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1275 Lines: 33 On Fri, 2008-08-15 at 16:05 -0400, Rick Troth wrote: > On Wed, 13 Aug 2008, Rusty Russell wrote: > > Can you hash the format string to generate the id? 6 hex digits should be > > enough, and your tool can check for clashes. As it's bad form to have > > identical strings for different semantics anyway, this seems to make sense. > > I second this suggestion (or propose something like it). > A short hash or even an index into some off-line table > lets the user hit the right page when looking for an explanation. The kmsg id is just that, an index into the table of message for a particular component. > I've been using a similar (and perhaps ugly to some eyes) > numeric message catalog for years (with token substitution and all). > The catalogs can be translated and then replaced with local language > so the users don't have to learn English (or French, or German, > or Japanese, or Chinese). That is what we are trying to achieve as well. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/