Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755884AbYHQRbq (ORCPT ); Sun, 17 Aug 2008 13:31:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753093AbYHQRbi (ORCPT ); Sun, 17 Aug 2008 13:31:38 -0400 Received: from yx-out-2324.google.com ([74.125.44.30]:65512 "EHLO yx-out-2324.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752672AbYHQRbh (ORCPT ); Sun, 17 Aug 2008 13:31:37 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references:x-google-sender-auth; b=ULpOVyrnuxKX17e79OWxOqsa9TMC0KDp669DJRWCxRQC2LT4ETGqvDKZvan+K/HW2o HT1v88Zsyu5dwNRcT9fP2Cz9ycK4ujXgBfpl5OUs4Cg+BpW2RHUtaa9eKA5VktG3HCpw TCYJYKBH5aXSwZPr/NwiDyaj8/buRHE6NatAo= Message-ID: Date: Sun, 17 Aug 2008 10:31:35 -0700 From: "Tim Hockin" To: schwidefsky@de.ibm.com Subject: Re: [patch 1/3] kmsg: Kernel message catalog macros. Cc: "Rusty Russell" , linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, lf_kernel_messages@lists.linux-foundation.org, "Andrew Morton" , "Michael Holzheu" , "Gerrit Huizenga" , "Greg Kroah-Hartman" , "Randy Dunlap" , "Jan Kara" , "Pavel Machek" , "Sam Ravnborg" , "Joe Perches" , "=?UTF-8?Q?Jochen_Vo=C3=9F?=" , "Kunai Takashi" , "Tim Bird" In-Reply-To: <1218994138.20098.6.camel@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20080730165656.118280544@de.ibm.com> <200808131433.02966.rusty@rustcorp.com.au> <1218733623.2651.14.camel@localhost> <200808150922.23277.rusty@rustcorp.com.au> <1218908985.6037.12.camel@localhost> <1218994138.20098.6.camel@localhost> X-Google-Sender-Auth: 27cb3027b5c7571a Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1478 Lines: 29 On Sun, Aug 17, 2008 at 10:28 AM, Martin Schwidefsky wrote: > On Sat, 2008-08-16 at 13:40 -0700, Tim Hockin wrote: >> >> > > Can you hash the format string to generate the id? 6 hex digits should >> >> > > be enough, and your tool can check for clashes. As it's bad form to have >> >> > > identical strings for different semantics anyway, this seems to make >> >> > > sense. >> >> > Ok, so a specialized version of printk will do the work to calculate >> > the hash. Only, what will we do if there ever is a conflict? The message >> > tag has to be unique. The shorter the hash is, the more likely a >> > collision gets. Don't know if 6 hash digits is enough to just ignore the >> > problem. >> >> And if you ever need to change the text that is in the format string? >> The hash changes. That seems exactly counter to your goal... > > The only problem here is trivial change like typos. Then the hash > changes although the message is semantically still the same. If the > message really changes, its id should change as well. That's what I meant. Never underestimate the urge to fix the printk(), because "hey, it's JUST A PRINTK". That's one of my motivations - to make it no longer just a printk. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/