Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752718AbYHRGiY (ORCPT ); Mon, 18 Aug 2008 02:38:24 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751323AbYHRGiR (ORCPT ); Mon, 18 Aug 2008 02:38:17 -0400 Received: from terminus.zytor.com ([198.137.202.10]:55395 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751216AbYHRGiQ (ORCPT ); Mon, 18 Aug 2008 02:38:16 -0400 Message-ID: <48A9180A.8020803@zytor.com> Date: Sun, 17 Aug 2008 23:34:50 -0700 From: "H. Peter Anvin" User-Agent: Thunderbird 2.0.0.16 (X11/20080723) MIME-Version: 1.0 To: Andi Kleen CC: "Maciej W. Rozycki" , David Fries , linux-kernel@vger.kernel.org Subject: Re: [PATCH] Fix i486 suspend to disk CR4 oops References: <20080818040340.GB17528@spacedout.fries.net> <48A8FC21.9060908@zytor.com> <87skt2270c.fsf@basil.nowhere.org> In-Reply-To: <87skt2270c.fsf@basil.nowhere.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 648 Lines: 18 Andi Kleen wrote: >>> >> The other alternative is to probe for the CPUID instruction (via >> EFLAGS.ID) -- CR4 is present if and only if CPUID exists. > > Can be already checked for with boot_cpu_data.extended_cpuid_level. > I believe you mean just plain cpuid_level (which is set to -1 if CPUID doesn't exist.) extended_cpuid_level is only defined on x86-64, but all x86-64 CPUs have CR4. -hpa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/