Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753427AbYHRVSS (ORCPT ); Mon, 18 Aug 2008 17:18:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752019AbYHRVSI (ORCPT ); Mon, 18 Aug 2008 17:18:08 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:41514 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751931AbYHRVSG (ORCPT ); Mon, 18 Aug 2008 17:18:06 -0400 Date: Mon, 18 Aug 2008 14:17:18 -0700 From: Andrew Morton To: Andreas Herrmann Cc: hannes@saeurebad.de, mingo@elte.hu, npiggin@suse.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH] alloc_bootmem_core: fix misaligned allocation of 1G page Message-Id: <20080818141718.bec87aa6.akpm@linux-foundation.org> In-Reply-To: <20080813193158.GB5985@alberich.amd.com> References: <20080812095336.GE5952@alberich.amd.com> <877iam41bk.fsf@skyscraper.fehenstaub.lan> <20080813164121.GA5985@alberich.amd.com> <87tzdo93tv.fsf@skyscraper.fehenstaub.lan> <20080813193158.GB5985@alberich.amd.com> X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.8.20; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 909 Lines: 27 On Wed, 13 Aug 2008 21:31:58 +0200 Andreas Herrmann wrote: > > Attached is a version that should be easier to read. Please > > double-check. > > Nice. > That's the preferred solution and should replace my initial fix. > > Reviewed-and-tested-by: Andreas Herrmann Johannes, I'm unsure whether that patch was the final version. Could you please resend it (or its successor)? With a more complete changelog, please. This: bootmem: fix aligning of node-relative indexes and offsets doesn't explain what needed fixing, nor how it was fixed, nor the consequences of leaving it unfixed, etc. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/